Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2017)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java

Issue 1982803002: Record UMA for snackbars shown for all purposes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: make identifier a parameter in constructor Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java
index 0e9c488bc08c31c632d84e02e0fc3ac317d6c66f..7340571e8945f8095081e50918edbf214da67fb6 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java
@@ -164,9 +164,8 @@ public class OfflinePageUtils {
Log.d(TAG, "showReloadSnackbar called with controller " + snackbarController);
Snackbar snackbar =
Snackbar.make(context.getString(R.string.offline_pages_viewing_offline_page),
- snackbarController, Snackbar.TYPE_ACTION)
- .setSingleLine(false)
- .setAction(context.getString(R.string.reload), tabId);
+ snackbarController, Snackbar.TYPE_ACTION, Snackbar.UMA_OFFLINE_PAGE_RELOAD)
+ .setSingleLine(false).setAction(context.getString(R.string.reload), tabId);
snackbar.setDuration(SNACKBAR_DURATION);
snackbarManager.showSnackbar(snackbar);
}
@@ -239,7 +238,7 @@ public class OfflinePageUtils {
int scale = batteryStatus.getIntExtra(BatteryManager.EXTRA_SCALE, -1);
if (scale == 0) return 0;
- int percentage = (int) Math.round(100 * level / (float) scale);
+ int percentage = Math.round(100 * level / (float) scale);
Log.d(TAG, "Battery Percentage is " + percentage);
return percentage;
}

Powered by Google App Engine
This is Rietveld 408576698