chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java - Issue 1982803002: Record UMA for snackbars shown for all purposes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

Issue 1982803002: Record UMA for snackbars shown for all purposes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: make identifier a parameter in constructor Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/snackbar/Snackbar.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

index cb1833de8f4d3749b9b361489a9eb3bc5895946e..dd5607c1cd81e65302ec9e26324dd46fff9fda9a 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

@@ -656,8 +656,10 @@ public class NewTabPage

};

}

Context context = mNewTabPageView.getContext();

- Snackbar snackbar = Snackbar.make(context.getString(R.string.most_visited_item_removed),

- mMostVisitedItemRemovedController, Snackbar.TYPE_ACTION)

+ Snackbar snackbar = Snackbar

+ .make(context.getString(R.string.most_visited_item_removed),

+ mMostVisitedItemRemovedController, Snackbar.TYPE_ACTION,

+ Snackbar.UMA_NTP_MOST_VISITED_DELETE_UNDO)

.setAction(context.getString(R.string.undo), url);

mTab.getSnackbarManager().showSnackbar(snackbar);

}