Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1982723002: Use FileTypePolicies for download danger classifications. (Closed)

Created:
4 years, 7 months ago by Nathan Parker
Modified:
4 years, 7 months ago
Reviewers:
asanka, nyquist
CC:
asanka, chromium-apps-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, extensions-reviews_chromium.org, grt+watch_chromium.org, jam, Jialiu Lin
Base URL:
https://chromium.googlesource.com/chromium/src.git@use_policies
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use FileTypePolicies for download danger classifications. This removes download_extensions.{h,cc} BUG=596555 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/70cf93b24ce79d7a5cec8eb6d64d21916e8d6dc9 Cr-Commit-Position: refs/heads/master@{#394914}

Patch Set 1 : Fix one test and reduce includes #

Patch Set 2 : fix 2 download tests, and set the default for missing-ext #

Patch Set 3 : Fix up comments and reflow some lines #

Patch Set 4 : rebase #

Patch Set 5 : Changes due to upstream CL changes. Singleton. #

Patch Set 6 : Fix bad rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+265 lines, -846 lines) Patch
M chrome/browser/android/download/chrome_download_delegate.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/download/chrome_download_manager_delegate.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/download/chrome_download_manager_delegate_unittest.cc View 1 2 3 4 7 chunks +27 lines, -20 lines 0 comments Download
M chrome/browser/download/download_browsertest.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/download/download_commands.cc View 1 2 3 4 3 chunks +4 lines, -3 lines 0 comments Download
D chrome/browser/download/download_extensions.h View 1 chunk +0 lines, -53 lines 0 comments Download
D chrome/browser/download/download_extensions.cc View 1 chunk +0 lines, -582 lines 0 comments Download
M chrome/browser/download/download_item_model.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/download/download_item_model.cc View 5 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/download/download_item_model_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/download/download_prefs.cc View 1 2 3 4 5 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/download/download_prefs_unittest.cc View 1 2 3 4 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/download/download_target_determiner.h View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/download/download_target_determiner.cc View 1 2 3 4 10 chunks +18 lines, -16 lines 0 comments Download
M chrome/browser/download/download_target_determiner_unittest.cc View 1 2 3 4 76 chunks +143 lines, -136 lines 0 comments Download
M chrome/browser/download/download_target_info.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/safe_browsing/README.md View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/safe_browsing/file_type_policies.h View 1 2 3 4 5 2 chunks +11 lines, -3 lines 0 comments Download
M chrome/common/safe_browsing/file_type_policies.cc View 1 2 3 4 1 chunk +17 lines, -0 lines 0 comments Download
M content/browser/download/download_stats.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (7 generated)
Nathan Parker
This is the second part of https://codereview.chromium.org/1979153002/ (review that first). Thanks!
4 years, 7 months ago (2016-05-16 22:23:53 UTC) #4
asanka
lgtm!
4 years, 7 months ago (2016-05-18 18:56:49 UTC) #5
Nathan Parker
nyquist: Please review small change to: chrome/browser/android/download/chrome_download_delegate.cc Thanks.
4 years, 7 months ago (2016-05-19 00:35:32 UTC) #7
nyquist
chrome/browser/android/download/ lgtm
4 years, 7 months ago (2016-05-19 23:30:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1982723002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1982723002/120001
4 years, 7 months ago (2016-05-19 23:51:13 UTC) #11
commit-bot: I haz the power
Committed patchset #6 (id:120001)
4 years, 7 months ago (2016-05-20 00:05:49 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 00:07:23 UTC) #14
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/70cf93b24ce79d7a5cec8eb6d64d21916e8d6dc9
Cr-Commit-Position: refs/heads/master@{#394914}

Powered by Google App Engine
This is Rietveld 408576698