Remove bogus DCHECK in content::UserMediaClientImpl and update unit test

Remove bogus DCHECK in content::UserMediaClientImpl and add unit test.

The DCHECK verifies that a reply must correspond to a live request, but that is not necessarily true due to device changes that may occur concurrently with the request.

BUG=607179
Committed: https://crrev.com/5da650481866cad8802589a1178c3537df79f437
Cr-Commit-Position: refs/heads/master@{#394144}

[Guido Urdaneta, 2016-05-16 17:06:15]

Description was changed from

==========
Remove bogus DCHECK in content::UserMediaClientImpl and add unit test

BUG=607179
==========

to

==========
Remove bogus DCHECK in content::UserMediaClientImpl and add unit test.

The DCHECK verifies that a reply most correspond to a live request, but that is
not necessarily true due to device changes that occur concurrently with the
request.

BUG=607179
==========

[Guido Urdaneta, 2016-05-17 07:32:09]

guidou@chromium.org changed reviewers:
+ perkj@chromium.org, phoglund@chromium.org

[Guido Urdaneta, 2016-05-17 07:32:38]

Description was changed from

==========
Remove bogus DCHECK in content::UserMediaClientImpl and add unit test.

The DCHECK verifies that a reply most correspond to a live request, but that is
not necessarily true due to device changes that occur concurrently with the
request.

BUG=607179
==========

to

==========
Remove bogus DCHECK in content::UserMediaClientImpl and add unit test.

The DCHECK verifies that a reply must correspond to a live request, but that is
not necessarily true due to device changes that may occur concurrently with the
request.

BUG=607179
==========

[Guido Urdaneta, 2016-05-17 07:33:04]

Hi, PTAL

[phoglund_chromium, 2016-05-17 07:56:26]

lgtm

https://codereview.chromium.org/1982593003/diff/1/content/renderer/media/user...
File content/renderer/media/user_media_client_impl_unittest.cc (right):

https://codereview.chromium.org/1982593003/diff/1/content/renderer/media/user...
content/renderer/media/user_media_client_impl_unittest.cc:267: // There may be
repeated replies due to device or configuration changes
Nit: end with .

https://codereview.chromium.org/1982593003/diff/1/content/renderer/media/user...
content/renderer/media/user_media_client_impl_unittest.cc:561:
TEST_F(UserMediaClientImplTest, EnumerateMediaDevices) {
We should avoid this style of unit test where we test more than one thing per
test. This test tests like 20 things. What you're doing is consistent with
what's already there though, so I will not ask you to rewrite the whole test :)

[Guido Urdaneta, 2016-05-17 08:05:43]

https://codereview.chromium.org/1982593003/diff/1/content/renderer/media/user...
File content/renderer/media/user_media_client_impl_unittest.cc (right):

https://codereview.chromium.org/1982593003/diff/1/content/renderer/media/user...
content/renderer/media/user_media_client_impl_unittest.cc:267: // There may be
repeated replies due to device or configuration changes
On 2016/05/17 07:56:26, phoglund_chrome wrote:
> Nit: end with .

Done.

https://codereview.chromium.org/1982593003/diff/1/content/renderer/media/user...
content/renderer/media/user_media_client_impl_unittest.cc:561:
TEST_F(UserMediaClientImplTest, EnumerateMediaDevices) {
On 2016/05/17 07:56:26, phoglund_chrome wrote:
> We should avoid this style of unit test where we test more than one thing per
> test. This test tests like 20 things. What you're doing is consistent with
> what's already there though, so I will not ask you to rewrite the whole test
:)

Acknowledged.

[perkj_chrome, 2016-05-17 15:23:55]

lgtm

[Guido Urdaneta, 2016-05-17 15:25:09]

The CQ bit was checked by guidou@chromium.org

[Guido Urdaneta, 2016-05-17 15:25:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
phoglund@chromium.org
Link to the patchset: https://codereview.chromium.org/1982593003/#ps20001
(title: "phoglund's nit")

[commit-bot: I haz the power, 2016-05-17 15:25:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1982593003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1982593003/20001

[commit-bot: I haz the power, 2016-05-17 16:33:05]

Description was changed from

==========
Remove bogus DCHECK in content::UserMediaClientImpl and add unit test.

The DCHECK verifies that a reply must correspond to a live request, but that is
not necessarily true due to device changes that may occur concurrently with the
request.

BUG=607179
==========

to

==========
Remove bogus DCHECK in content::UserMediaClientImpl and add unit test.

The DCHECK verifies that a reply must correspond to a live request, but that is
not necessarily true due to device changes that may occur concurrently with the
request.

BUG=607179
==========

[commit-bot: I haz the power, 2016-05-17 16:33:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-17 16:35:07]

Description was changed from

==========
Remove bogus DCHECK in content::UserMediaClientImpl and add unit test.

The DCHECK verifies that a reply must correspond to a live request, but that is
not necessarily true due to device changes that may occur concurrently with the
request.

BUG=607179
==========

to

==========
Remove bogus DCHECK in content::UserMediaClientImpl and add unit test.

The DCHECK verifies that a reply must correspond to a live request, but that is
not necessarily true due to device changes that may occur concurrently with the
request.

BUG=607179

Committed: https://crrev.com/5da650481866cad8802589a1178c3537df79f437
Cr-Commit-Position: refs/heads/master@{#394144}
==========

[commit-bot: I haz the power, 2016-05-17 16:35:08]

Patchset 2 (id:??) landed as
https://crrev.com/5da650481866cad8802589a1178c3537df79f437
Cr-Commit-Position: refs/heads/master@{#394144}