content/renderer/media/user_media_client_impl.cc - Issue 1982593003: Remove bogus DCHECK in content::UserMediaClientImpl and update unit test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/user_media_client_impl.cc

Issue 1982593003: Remove bogus DCHECK in content::UserMediaClientImpl and update unit test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: phoglund's nit Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/media/user_media_client_impl.cc

diff --git a/content/renderer/media/user_media_client_impl.cc b/content/renderer/media/user_media_client_impl.cc

index 68c80ea34830ef053243ca8bf8a5d01c43fa436c..1a8df36355cadac04052adc7587c0a3959eab7b7 100644

--- a/content/renderer/media/user_media_client_impl.cc

+++ b/content/renderer/media/user_media_client_impl.cc

@@ -753,7 +753,8 @@ void UserMediaClientImpl::OnDevicesEnumerated(

DVLOG(1) << "UserMediaClientImpl::OnDevicesEnumerated(" << request_id << ")";

MediaDevicesRequestInfo* request = FindMediaDevicesRequestInfo(request_id);

- DCHECK(request);

+ if (!request)

+ return;

if (request_id == request->audio_input_request_id) {

request->has_audio_input_returned = true;

« no previous file with comments | « no previous file | content/renderer/media/user_media_client_impl_unittest.cc » ('j') | no next file with comments »