Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1982553002: Fix manifest loading for catalog and shell. (Closed)

Created:
4 years, 7 months ago by Ben Goodger (Google)
Modified:
4 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@client2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix manifest loading for catalog and shell. When I switched to scanning the applications directory, manifest loading for the catalog & shell stopped working & their line items in the task viewer started showing blank. R=sky@chromium.org BUG= Committed: https://crrev.com/39e191aa8940d41752eea8f0a303d359c89e63db Cr-Commit-Position: refs/heads/master@{#394215}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M services/catalog/reader.cc View 1 chunk +3 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
Ben Goodger (Google)
4 years, 7 months ago (2016-05-16 19:46:52 UTC) #1
sky
LGTM
4 years, 7 months ago (2016-05-16 19:54:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1982553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1982553002/1
4 years, 7 months ago (2016-05-17 19:13:48 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-17 20:27:49 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 20:30:12 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/39e191aa8940d41752eea8f0a303d359c89e63db
Cr-Commit-Position: refs/heads/master@{#394215}

Powered by Google App Engine
This is Rietveld 408576698