Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 1977263002: Add another client of the navigation service. (Closed)

Created:
4 years, 7 months ago by Ben Goodger (Google)
Modified:
4 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@browser
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add another client of the navigation service. Just a window that loads a single page. Intended to show that multiple independent embedders of navigable views all utilize a shared navigation service & are themselves tiny. R=sky@chromium.org BUG= Committed: https://crrev.com/979c48cf41abe0410a12290ef13b8c85cd6227b7 Cr-Commit-Position: refs/heads/master@{#394182}

Patch Set 1 #

Total comments: 1

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+349 lines, -0 lines) Patch
M mash/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
A mash/webtest/BUILD.gn View 1 2 1 chunk +62 lines, -0 lines 0 comments Download
A mash/webtest/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
A mash/webtest/main.cc View 1 chunk +12 lines, -0 lines 0 comments Download
A mash/webtest/manifest.json View 1 chunk +11 lines, -0 lines 0 comments Download
A mash/webtest/webtest.h View 1 chunk +62 lines, -0 lines 0 comments Download
A mash/webtest/webtest.cc View 1 chunk +198 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
Ben Goodger (Google)
4 years, 7 months ago (2016-05-16 19:46:49 UTC) #1
sky
LGTM https://codereview.chromium.org/1977263002/diff/1/mash/webtest/webtest.h File mash/webtest/webtest.h (right): https://codereview.chromium.org/1977263002/diff/1/mash/webtest/webtest.h#newcode24 mash/webtest/webtest.h:24: class Webtest Add description.
4 years, 7 months ago (2016-05-16 19:53:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1977263002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1977263002/20001
4 years, 7 months ago (2016-05-17 03:16:16 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/188682) linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 7 months ago (2016-05-17 03:20:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1977263002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1977263002/40001
4 years, 7 months ago (2016-05-17 03:29:42 UTC) #10
commit-bot: I haz the power
Failed to apply patch for mash/BUILD.gn: While running git apply --index -3 -p1; error: patch ...
4 years, 7 months ago (2016-05-17 04:47:00 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1977263002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1977263002/40001
4 years, 7 months ago (2016-05-17 19:03:07 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-17 19:11:57 UTC) #16
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 19:14:52 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/979c48cf41abe0410a12290ef13b8c85cd6227b7
Cr-Commit-Position: refs/heads/master@{#394182}

Powered by Google App Engine
This is Rietveld 408576698