Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1981953003: Stop using WaitMessage in MessagePumpForUI::WaitForWork (Closed)

Created:
4 years, 7 months ago by stanisc
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Stop using WaitMessage in MessagePumpForUI::WaitForWork When WaitMessage is called it ignores the current delay timeout and might end up waiting an arbitrary time. See the bug for the explanation. The fix is to loop back and call MsgWaitForMultipleObjectEx again with the remaining timeout. BUG=610005, 596190 Review-Url: https://codereview.chromium.org/1953393002 Cr-Commit-Position: refs/heads/master@{#393375} (cherry picked from commit 05e1178680e47f4263f9c7087dad1d8e099a5027) Committed: https://chromium.googlesource.com/chromium/src/+/11489eff83fe66f994f8d824f5327b15dde0e2e7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -29 lines) Patch
M base/message_loop/message_pump_win.cc View 1 chunk +38 lines, -29 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
stanisc
4 years, 7 months ago (2016-05-16 21:04:22 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
11489eff83fe66f994f8d824f5327b15dde0e2e7.

Powered by Google App Engine
This is Rietveld 408576698