Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1413)

Issue 1981843003: Touch Action could cause wheel gestures to be filtered. (Closed)

Created:
4 years, 7 months ago by dtapuska
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Touch Action could cause wheel gestures to be filtered. If the source device is not touchscreen the touch action filter should not do anything. A certain drop list in Google maps was failing to scroll via wheel scrolling because it had installed a touch action none filter. BUG=607495 Review-Url: https://codereview.chromium.org/1971273002 Cr-Commit-Position: refs/heads/master@{#393348} (cherry picked from commit 3a5f4dbe106611593f05ba7ae163d1660f219f6a) Committed: https://chromium.googlesource.com/chromium/src/+/984f294b46d7fbc882a14d7a8352b88c3c4f8e39

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -25 lines) Patch
M content/browser/renderer_host/input/input_router_impl_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/touch_action_filter.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/touch_action_filter_unittest.cc View 14 chunks +28 lines, -13 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/common/input/synthetic_web_input_event_builders.h View 1 chunk +4 lines, -2 lines 0 comments Download
M content/common/input/synthetic_web_input_event_builders.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dtapuska
4 years, 7 months ago (2016-05-16 12:41:33 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
984f294b46d7fbc882a14d7a8352b88c3c4f8e39.

Powered by Google App Engine
This is Rietveld 408576698