Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1981823003: Add deep report for BENCHMARK_MEMORY (Closed)

Created:
4 years, 7 months ago by keishi
Modified:
4 years, 7 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, darin-cc_chromium.org, jam, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add deep report for BENCHMARK_MEMORY Adds BENCHMARK_MEMORY tracing config. And adds deep report triggered on low memory. BUG=612102 Committed: https://crrev.com/4743ab9d5ecd967717bcffe6e68063c0d81c1ff8 Cr-Commit-Position: refs/heads/master@{#396401}

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : limit to 5sec #

Total comments: 6

Patch Set 4 : fixed heavy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M chrome/browser/tracing/navigation_tracing.cc View 1 2 3 1 chunk +12 lines, -0 lines 0 comments Download
M content/browser/tracing/background_tracing_config_impl.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/tracing/background_tracing_config_impl.cc View 1 2 3 3 chunks +8 lines, -0 lines 0 comments Download
M content/browser/tracing/background_tracing_config_unittest.cc View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/tracing/background_tracing_manager_impl.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (10 generated)
keishi
PTAL google3 side change: https://critique.corp.google.com/#review/122397505
4 years, 7 months ago (2016-05-17 06:28:55 UTC) #3
Primiano Tucci (use gerrit)
What does this cause if enabled? Is this for deep or bulk reports? As it ...
4 years, 7 months ago (2016-05-17 06:41:45 UTC) #5
oystein (OOO til 10th of July)
On 2016/05/17 06:41:45, Primiano Tucci wrote: > What does this cause if enabled? Is this ...
4 years, 7 months ago (2016-05-17 15:54:38 UTC) #6
keishi
I've modified the CL to use deep reports. I would like to start collecting/analyzing some ...
4 years, 7 months ago (2016-05-24 06:40:09 UTC) #8
keishi
On 2016/05/24 06:40:09, keishi wrote: > I've modified the CL to use deep reports. I ...
4 years, 7 months ago (2016-05-24 06:40:45 UTC) #9
ssid
Is there a plan to set different triggers for deep reports? Tracing for 30 seconds ...
4 years, 7 months ago (2016-05-25 02:02:13 UTC) #11
keishi
On 2016/05/25 02:02:13, ssid wrote: > Is there a plan to set different triggers for ...
4 years, 7 months ago (2016-05-25 13:27:23 UTC) #12
oystein (OOO til 10th of July)
On 2016/05/25 13:27:23, keishi wrote: > On 2016/05/25 02:02:13, ssid wrote: > > Is there ...
4 years, 7 months ago (2016-05-25 16:26:41 UTC) #14
ssid
On 2016/05/25 16:26:41, Oystein wrote: > On 2016/05/25 13:27:23, keishi wrote: > > On 2016/05/25 ...
4 years, 7 months ago (2016-05-25 16:51:24 UTC) #15
keishi
For this first experiment I would like to collect: - at least two detailed dumps ...
4 years, 7 months ago (2016-05-26 05:37:04 UTC) #16
ssid
On 2016/05/26 05:37:04, keishi wrote: > For this first experiment I would like to collect: ...
4 years, 7 months ago (2016-05-26 06:27:52 UTC) #17
oystein (OOO til 10th of July)
lgtm, let's see what we get!
4 years, 7 months ago (2016-05-26 15:53:35 UTC) #18
ssid
Looks good. Please rename to heavy everywhere. https://codereview.chromium.org/1981823003/diff/40001/chrome/browser/tracing/navigation_tracing.cc File chrome/browser/tracing/navigation_tracing.cc (right): https://codereview.chromium.org/1981823003/diff/40001/chrome/browser/tracing/navigation_tracing.cc#newcode78 chrome/browser/tracing/navigation_tracing.cc:78: rules_dict->SetString("category", "BENCHMARK_MEMORY"); ...
4 years, 7 months ago (2016-05-27 01:08:10 UTC) #19
keishi
Thanks! https://codereview.chromium.org/1981823003/diff/40001/chrome/browser/tracing/navigation_tracing.cc File chrome/browser/tracing/navigation_tracing.cc (right): https://codereview.chromium.org/1981823003/diff/40001/chrome/browser/tracing/navigation_tracing.cc#newcode78 chrome/browser/tracing/navigation_tracing.cc:78: rules_dict->SetString("category", "BENCHMARK_MEMORY"); On 2016/05/27 01:08:10, ssid wrote: > ...
4 years, 7 months ago (2016-05-27 04:29:07 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1981823003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1981823003/60001
4 years, 7 months ago (2016-05-27 04:29:54 UTC) #23
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-27 05:48:32 UTC) #25
commit-bot: I haz the power
4 years, 7 months ago (2016-05-27 05:49:49 UTC) #27
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/4743ab9d5ecd967717bcffe6e68063c0d81c1ff8
Cr-Commit-Position: refs/heads/master@{#396401}

Powered by Google App Engine
This is Rietveld 408576698