Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6206)

Unified Diff: chrome/browser/tracing/navigation_tracing.cc

Issue 1981823003: Add deep report for BENCHMARK_MEMORY (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed heavy Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/tracing/background_tracing_config_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/tracing/navigation_tracing.cc
diff --git a/chrome/browser/tracing/navigation_tracing.cc b/chrome/browser/tracing/navigation_tracing.cc
index 197ecc2195dae518b88f2b88c24a8e0444e289f1..83f55c5fe4a597d160a5fc5fe07ba92633a770e2 100644
--- a/chrome/browser/tracing/navigation_tracing.cc
+++ b/chrome/browser/tracing/navigation_tracing.cc
@@ -70,6 +70,18 @@ void SetupNavigationTracing() {
rules_dict->SetString("category", "BENCHMARK_DEEP");
rules_list->Append(std::move(rules_dict));
}
+ {
+ std::unique_ptr<base::DictionaryValue> rules_dict(
+ new base::DictionaryValue());
+ rules_dict->SetString("rule",
+ "MONITOR_AND_DUMP_WHEN_SPECIFIC_HISTOGRAM_AND_VALUE");
+ rules_dict->SetString("category", "BENCHMARK_MEMORY_HEAVY");
+ rules_dict->SetString("histogram_name", "V8.GCLowMemoryNotification");
+ rules_dict->SetInteger("trigger_delay", 5);
+ rules_dict->SetInteger("histogram_lower_value", 0);
+ rules_dict->SetInteger("histogram_upper_value", 10000);
+ rules_list->Append(std::move(rules_dict));
+ }
dict.Set("configs", std::move(rules_list));
std::unique_ptr<content::BackgroundTracingConfig> config(
« no previous file with comments | « no previous file | content/browser/tracing/background_tracing_config_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698