third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp - Issue 1981823002: Remove OwnPtr::release() calls in platform/ (part 1).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp

Issue 1981823002: Remove OwnPtr::release() calls in platform/ (part 1). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/PictureSnapshot.cpp ('k') | third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp b/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp

index 9f269730b17d8327bf5f3466981213c0c1eed5ba..7e9b5702d719e69609a3b7a10201bc172aa2ad2a 100644

--- a/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp

+++ b/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp

@@ -98,11 +98,11 @@ protected:

{

OwnPtr<MockSurfaceFactory> surfaceFactory = adoptPtr(new MockSurfaceFactory());

m_surfaceFactory = surfaceFactory.get();

- OwnPtr<RecordingImageBufferSurface> testSurface = adoptPtr(new RecordingImageBufferSurface(IntSize(10, 10), surfaceFactory.release()));

+ OwnPtr<RecordingImageBufferSurface> testSurface = adoptPtr(new RecordingImageBufferSurface(IntSize(10, 10), std::move(surfaceFactory)));

m_testSurface = testSurface.get();

// We create an ImageBuffer in order for the testSurface to be

// properly initialized with a GraphicsContext

- m_imageBuffer = ImageBuffer::create(testSurface.release());

+ m_imageBuffer = ImageBuffer::create(std::move(testSurface));

EXPECT_FALSE(!m_imageBuffer);

m_fakeImageBufferClient = adoptPtr(new FakeImageBufferClient(m_imageBuffer.get()));

m_imageBuffer->setClient(m_fakeImageBufferClient.get());