third_party/WebKit/Source/platform/graphics/PictureSnapshot.cpp - Issue 1981823002: Remove OwnPtr::release() calls in platform/ (part 1).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/PictureSnapshot.cpp

Issue 1981823002: Remove OwnPtr::release() calls in platform/ (part 1). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.cpp ('k') | third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/PictureSnapshot.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/PictureSnapshot.cpp b/third_party/WebKit/Source/platform/graphics/PictureSnapshot.cpp

index fbe787042993f37868cb9748fc0abf8de9729dfa..9676b2d2e0d266b286d1c3ae5f3a58e5b63817a2 100644

--- a/third_party/WebKit/Source/platform/graphics/PictureSnapshot.cpp

+++ b/third_party/WebKit/Source/platform/graphics/PictureSnapshot.cpp

@@ -141,7 +141,7 @@ PassOwnPtr<Vector<char>> PictureSnapshot::replay(unsigned fromStep, unsigned toS

return nullptr;

base64Encode(encodedImage, *base64Data);

- return base64Data.release();

+ return base64Data;

}

PassOwnPtr<PictureSnapshot::Timings> PictureSnapshot::profile(unsigned minRepeatCount, double minDuration, const FloatRect* clipRect) const

@@ -169,7 +169,7 @@ PassOwnPtr<PictureSnapshot::Timings> PictureSnapshot::profile(unsigned minRepeat

m_picture->playback(&canvas);

now = WTF::monotonicallyIncreasingTime();

}

- return timings.release();

+ return timings;

}

PassRefPtr<JSONArray> PictureSnapshot::snapshotCommandLog() const