Issue 1981643002: Combine OnCongestionWindowChange and OnRttChange to OnCongestionChange in QuicSentPacketManager::Ne…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1981643002: Combine OnCongestionWindowChange and OnRttChange to OnCongestionChange in QuicSentPacketManager::Ne… (Closed)

Created:
4 years, 7 months ago by Buck

Modified:
4 years, 7 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, Fan Yang

Base URL:
https://chromium.googlesource.com/chromium/src.git@121732198

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Combine OnCongestionWindowChange and OnRttChange to OnCongestionChange in QuicSentPacketManager::NetworkChangeVisitor. No functional change expected. Merge internal change: 121761990 R=rch@chromium.org BUG=

Patch Set 1 #

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -72 lines)			Patch
M	net/quic/quic_connection.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	net/quic/quic_connection.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	net/quic/quic_sent_packet_manager.h	View	1 chunk	+2 lines, -6 lines	0 comments	Download
M	net/quic/quic_sent_packet_manager.cc	View	4 chunks	+2 lines, -10 lines	0 comments	Download
M	net/quic/quic_sent_packet_manager_test.cc	View	24 chunks	+25 lines, -49 lines	0 comments	Download
M	net/quic/test_tools/quic_test_utils.h	View	1 chunk	+1 line, -2 lines	0 comments	Download

Depends on Patchset:

Issue 1979633003 Patch 1

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Buck

On 2016/05/14 01:43:07, Ryan Hamilton wrote: > Do you need to change quic_connection_logger, too? I ...

4 years, 7 months ago (2016-05-14 06:00:20 UTC) #3

lgtm

oh, you're right.  my mistake!

Expand Messages | Collapse Messages