Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: net/quic/quic_sent_packet_manager.cc

Issue 1981643002: Combine OnCongestionWindowChange and OnRttChange to OnCongestionChange in QuicSentPacketManager::Ne… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@121732198
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_sent_packet_manager.h ('k') | net/quic/quic_sent_packet_manager_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_sent_packet_manager.cc
diff --git a/net/quic/quic_sent_packet_manager.cc b/net/quic/quic_sent_packet_manager.cc
index 6cb7b3b2fdfaec33e0df86389e2acbf0489c52ab..3b6e9df0fde1ae9b62c0483b220fb45e4d346698 100644
--- a/net/quic/quic_sent_packet_manager.cc
+++ b/net/quic/quic_sent_packet_manager.cc
@@ -118,10 +118,6 @@ void QuicSentPacketManager::SetFromConfig(const QuicConfig& config) {
min(kMaxInitialRoundTripTimeUs,
config.GetInitialRoundTripTimeUsToSend())));
}
- // Initial RTT may have changed.
- if (network_change_visitor_ != nullptr) {
- network_change_visitor_->OnRttChange();
- }
// TODO(ianswett): BBR is currently a server only feature.
if (FLAGS_quic_allow_bbr && config.HasReceivedConnectionOptions() &&
ContainsQuicTag(config.ReceivedConnectionOptions(), kTBBR)) {
@@ -185,7 +181,7 @@ void QuicSentPacketManager::SetFromConfig(const QuicConfig& config) {
send_algorithm_->SetFromConfig(config, perspective_);
if (network_change_visitor_ != nullptr) {
- network_change_visitor_->OnCongestionWindowChange();
+ network_change_visitor_->OnCongestionChange();
}
}
@@ -290,7 +286,7 @@ void QuicSentPacketManager::MaybeInvokeCongestionEvent(
packets_acked_.clear();
packets_lost_.clear();
if (network_change_visitor_ != nullptr) {
- network_change_visitor_->OnCongestionWindowChange();
+ network_change_visitor_->OnCongestionChange();
}
}
@@ -772,10 +768,6 @@ bool QuicSentPacketManager::MaybeUpdateRTT(const QuicAckFrame& ack_frame,
ack_receive_time.Subtract(transmission_info.sent_time);
rtt_stats_.UpdateRtt(send_delta, ack_frame.ack_delay_time, ack_receive_time);
- if (network_change_visitor_ != nullptr) {
- network_change_visitor_->OnRttChange();
- }
-
return true;
}
« no previous file with comments | « net/quic/quic_sent_packet_manager.h ('k') | net/quic/quic_sent_packet_manager_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698