Issue 198163002: MIPS: Reland "Pass a Code object to Assembler::(set_)target_address_at for use by ool constant pool…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 198163002: MIPS: Reland "Pass a Code object to Assembler::(set_)target_address_at for use by ool constant pool… (Closed)

Created:
6 years, 9 months ago by kilvadyb

Modified:
6 years, 9 months ago

Reviewers:
Paul Lind, danno, kisg, palfia, rmcilroy, dusmil

CC:
v8-dev

Base URL:
https://github.com/v8/v8.git@gbl

Visibility:
Public.

More Reviews

Description

MIPS: Reland "Pass a Code object to Assembler::(set_)target_address_at for use by ool constant pool." Port r19856 (0546217) Original commit message: The ool constant pool will require a pointer to the code's constant pool when updating or reading target addresses using set_target_address_at() and target_address_at(). BUG=

Patch Set 1 #

Total comments: 1

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -11 lines)			Patch
M	src/mips/assembler-mips.h	View	2 chunks	+22 lines, -1 line	0 comments	Download
M	src/mips/assembler-mips-inl.h	View	8 chunks	+12 lines, -10 lines	0 comments	Download
M	src/mips/frames-mips.h	View	1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paul Lind

LGTM. I'll fix the nit on landing. https://codereview.chromium.org/198163002/diff/1/src/mips/frames-mips.h File src/mips/frames-mips.h (right): https://codereview.chromium.org/198163002/diff/1/src/mips/frames-mips.h#newcode166 src/mips/frames-mips.h:166: static const ...

6 years, 9 months ago (2014-03-12 22:07:14 UTC) #2

Committed as r19867.

Expand Messages | Collapse Messages