Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 1981333004: Set the "mutable format" bit on sRGB images at creation time. (Closed)

Created:
4 years, 7 months ago by Brian Osman
Modified:
4 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Set the "mutable format" bit on sRGB images at creation time. This allows us to later create an image view with a linear format, for legacy-mode non-sRGB access. No actual API change (just a comment change in public header). TBR=bsalomon@google.com BUG=skia:5308 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1981333004 Committed: https://skia.googlesource.com/skia/+/7888f780d85ced5c572f0227c16b88ed59bcffe5

Patch Set 1 #

Patch Set 2 : Document restriction on API for wrapped images #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M include/gpu/vk/GrVkTypes.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/gpu/vk/GrVkImage.cpp View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
Brian Osman
4 years, 7 months ago (2016-05-17 17:54:56 UTC) #3
jvanverth1
lgtm
4 years, 7 months ago (2016-05-17 18:00:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1981333004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1981333004/20001
4 years, 7 months ago (2016-05-17 18:23:42 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/9778)
4 years, 7 months ago (2016-05-17 18:25:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1981333004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1981333004/20001
4 years, 7 months ago (2016-05-17 18:32:17 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 18:47:36 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/7888f780d85ced5c572f0227c16b88ed59bcffe5

Powered by Google App Engine
This is Rietveld 408576698