Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: include/gpu/vk/GrVkTypes.h

Issue 1981333004: Set the "mutable format" bit on sRGB images at creation time. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Document restriction on API for wrapped images Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/gpu/vk/GrVkImage.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/gpu/vk/GrVkTypes.h
diff --git a/include/gpu/vk/GrVkTypes.h b/include/gpu/vk/GrVkTypes.h
index deee409e6f6186e189127440dee24f3620c67c39..94b765f668329c6f99922bb1c7c3de1c1674562b 100644
--- a/include/gpu/vk/GrVkTypes.h
+++ b/include/gpu/vk/GrVkTypes.h
@@ -30,6 +30,10 @@
* Vulkan textures are really const GrVkImageInfo*
*/
struct GrVkImageInfo {
+ /**
+ * If the image's format is sRGB (GrVkFormatIsSRGB returns true), then the image must have
+ * been created with VkImageCreateFlags containing VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT.
+ */
VkImage fImage;
VkDeviceMemory fAlloc; // can be VK_NULL_HANDLE iff Tex is an RT and uses borrow semantics
VkImageTiling fImageTiling;
« no previous file with comments | « no previous file | src/gpu/vk/GrVkImage.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698