Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 1981193004: i18n of Find bar to use locally correct numeric glyphs (Closed)

Created:
4 years, 7 months ago by Greg Levin
Modified:
4 years, 7 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina, jungshik at Google
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

i18n of Find bar to use locally correct numeric glyphs BUG=612589 TEST=Switch to language with non-Arabic numerals (e.g., Persian), CTRL+F to find on page, enter some word. Check that numbers (e.g., "3 of 12") are rendered with non-Arabic numerals. Committed: https://crrev.com/cd3bec1dbe65f0a1bf995e2afcd8fa445f7f4f71 Cr-Commit-Position: refs/heads/master@{#394995}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/ui/views/find_bar_view.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Greg Levin
Hey, pkasting@. Here's a simple i18n one. Please have a look!
4 years, 7 months ago (2016-05-19 12:35:27 UTC) #2
Peter Kasting
LGTM
4 years, 7 months ago (2016-05-19 21:15:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1981193004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1981193004/1
4 years, 7 months ago (2016-05-20 03:34:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-20 04:20:22 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 04:23:36 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd3bec1dbe65f0a1bf995e2afcd8fa445f7f4f71
Cr-Commit-Position: refs/heads/master@{#394995}

Powered by Google App Engine
This is Rietveld 408576698