Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: chrome/browser/ui/views/find_bar_view.cc

Issue 1981193004: i18n of Find bar to use locally correct numeric glyphs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/find_bar_view.cc
diff --git a/chrome/browser/ui/views/find_bar_view.cc b/chrome/browser/ui/views/find_bar_view.cc
index 7e76a4c17354f0bd9bed5208ee3c56fbce4442d1..380fa332ba0ce813f64caa7be59a19483d595f30 100644
--- a/chrome/browser/ui/views/find_bar_view.cc
+++ b/chrome/browser/ui/views/find_bar_view.cc
@@ -6,9 +6,9 @@
#include <algorithm>
+#include "base/i18n/number_formatting.h"
#include "base/macros.h"
#include "base/memory/ptr_util.h"
-#include "base/strings/string_number_conversions.h"
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/profiles/profile.h"
@@ -236,9 +236,9 @@ void FindBarView::UpdateForResult(const FindNotificationDetails& result,
return;
}
- match_count_text_->SetText(l10n_util::GetStringFUTF16(IDS_FIND_IN_PAGE_COUNT,
- base::IntToString16(result.active_match_ordinal()),
- base::IntToString16(result.number_of_matches())));
+ match_count_text_->SetText(l10n_util::GetStringFUTF16(
+ IDS_FIND_IN_PAGE_COUNT, base::FormatNumber(result.active_match_ordinal()),
+ base::FormatNumber(result.number_of_matches())));
UpdateMatchCountAppearance(result.number_of_matches() == 0 &&
result.final_update());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698