build/android/pylib/local/device/local_device_instrumentation_test_run.py - Issue 1981043004: Added the --screenshot option.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/local/device/local_device_instrumentation_test_run.py

Issue 1981043004: Added the --screenshot option. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: made screenshot and screenshot-dir both work Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/local/device/local_device_instrumentation_test_run.py

diff --git a/build/android/pylib/local/device/local_device_instrumentation_test_run.py b/build/android/pylib/local/device/local_device_instrumentation_test_run.py

index 2d574de1fd2017149062cb63c9c4eb12e6023bad..9da3f791cca302e4734fddca052966b2918e1855 100644

--- a/build/android/pylib/local/device/local_device_instrumentation_test_run.py

+++ b/build/android/pylib/local/device/local_device_instrumentation_test_run.py

@@ -263,6 +263,9 @@ class LocalDeviceInstrumentationTestRun(

if any(r.GetType() not in (base_test_result.ResultType.PASS,

base_test_result.ResultType.SKIP)

for r in results):

+ if self._test_instance.screenshot_dir:

+ saved_dir = device.TakeScreenshot(self._test_instance.screenshot_dir)

jbudorick 2016/05/18 19:31:17 Thought about this a bit more. Let's instead speci

BigBossZhiling 2016/05/18 22:30:18 Done.

+ logging.info('saved screenshot at %s', saved_dir)

jbudorick 2016/05/18 19:31:17 nit: this should be logging.info('Saved screens

BigBossZhiling 2016/05/18 22:30:18 Done.

logging.info('detected failure in %s. raw output:', test_display_name)

for l in output:

logging.info(' %s', l)

« no previous file with comments | « build/android/pylib/instrumentation/instrumentation_test_instance.py ('k') | build/android/test_runner.py » ('j') | no next file with comments »