Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Side by Side Diff: build/android/pylib/local/device/local_device_instrumentation_test_run.py

Issue 1981043004: Added the --screenshot option. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: made screenshot and screenshot-dir both work Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import logging 5 import logging
6 import re 6 import re
7 import time 7 import time
8 8
9 from devil.android import device_errors 9 from devil.android import device_errors
10 from devil.android import flag_changer 10 from devil.android import flag_changer
(...skipping 245 matching lines...) Expand 10 before | Expand all | Expand 10 after
256 if r.GetName() == test_name: 256 if r.GetName() == test_name:
257 r.SetName(test_display_name) 257 r.SetName(test_display_name)
258 if DidPackageCrashOnDevice(self._test_instance.test_package, device): 258 if DidPackageCrashOnDevice(self._test_instance.test_package, device):
259 for r in results: 259 for r in results:
260 if r.GetType() == base_test_result.ResultType.UNKNOWN: 260 if r.GetType() == base_test_result.ResultType.UNKNOWN:
261 r.SetType(base_test_result.ResultType.CRASH) 261 r.SetType(base_test_result.ResultType.CRASH)
262 262
263 if any(r.GetType() not in (base_test_result.ResultType.PASS, 263 if any(r.GetType() not in (base_test_result.ResultType.PASS,
264 base_test_result.ResultType.SKIP) 264 base_test_result.ResultType.SKIP)
265 for r in results): 265 for r in results):
266 if self._test_instance.screenshot_dir:
267 saved_dir = device.TakeScreenshot(self._test_instance.screenshot_dir)
jbudorick 2016/05/18 19:31:17 Thought about this a bit more. Let's instead speci
BigBossZhiling 2016/05/18 22:30:18 Done.
268 logging.info('saved screenshot at %s', saved_dir)
jbudorick 2016/05/18 19:31:17 nit: this should be logging.info('Saved screens
BigBossZhiling 2016/05/18 22:30:18 Done.
266 logging.info('detected failure in %s. raw output:', test_display_name) 269 logging.info('detected failure in %s. raw output:', test_display_name)
267 for l in output: 270 for l in output:
268 logging.info(' %s', l) 271 logging.info(' %s', l)
269 if (not self._env.skip_clear_data 272 if (not self._env.skip_clear_data
270 and self._test_instance.package_info): 273 and self._test_instance.package_info):
271 permissions = ( 274 permissions = (
272 self._test_instance.apk_under_test.GetPermissions() 275 self._test_instance.apk_under_test.GetPermissions()
273 if self._test_instance.apk_under_test 276 if self._test_instance.apk_under_test
274 else None) 277 else None)
275 device.ClearApplicationState(self._test_instance.package_info.package, 278 device.ClearApplicationState(self._test_instance.package_info.package,
(...skipping 25 matching lines...) Expand all
301 timeout = v 304 timeout = v
302 break 305 break
303 else: 306 else:
304 logging.warning('Using default 1 minute timeout for %s', test_name) 307 logging.warning('Using default 1 minute timeout for %s', test_name)
305 timeout = 60 308 timeout = 60
306 309
307 timeout *= cls._GetTimeoutScaleFromAnnotations(annotations) 310 timeout *= cls._GetTimeoutScaleFromAnnotations(annotations)
308 311
309 return timeout 312 return timeout
310 313
OLDNEW
« no previous file with comments | « build/android/pylib/instrumentation/instrumentation_test_instance.py ('k') | build/android/test_runner.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698