build/android/pylib/local/device/local_device_instrumentation_test_run.py - Issue 1981043004: Added the --screenshot option.

Unified Diff: build/android/pylib/local/device/local_device_instrumentation_test_run.py

Issue 1981043004: Added the --screenshot option. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« build/android/pylib/instrumentation/instrumentation_test_instance.py ('K') | « build/android/pylib/instrumentation/instrumentation_test_instance.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: build/android/pylib/local/device/local_device_instrumentation_test_run.py

diff --git a/build/android/pylib/local/device/local_device_instrumentation_test_run.py b/build/android/pylib/local/device/local_device_instrumentation_test_run.py

index 2d574de1fd2017149062cb63c9c4eb12e6023bad..4f6c1b18f11e6bb396d7901e00c85d1930a02567 100644

--- a/build/android/pylib/local/device/local_device_instrumentation_test_run.py

+++ b/build/android/pylib/local/device/local_device_instrumentation_test_run.py

@@ -264,6 +264,8 @@ class LocalDeviceInstrumentationTestRun(

base_test_result.ResultType.SKIP)

for r in results):

logging.info('detected failure in %s. raw output:', test_display_name)

+ if self._test_instance.screenshot_failures:

mikecase (-- gone --) 2016/05/16 23:40:50 I can't imagine this takes a screenshot before Chr

BigBossZhiling 2016/05/18 17:46:11 You are right. lol. It is only useful in a few occ

+ device.TakeScreenshot()

mikecase (-- gone --) 2016/05/16 23:40:50 This should probably specify the host_path arg for

jbudorick 2016/05/17 00:01:16 +1, we should be able to specify this.

BigBossZhiling 2016/05/18 17:46:12 Done.

for l in output:

logging.info(' %s', l)

if (not self._env.skip_clear_data