build/android/pylib/instrumentation/instrumentation_test_instance.py - Issue 1981043004: Added the --screenshot option.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/instrumentation/instrumentation_test_instance.py

Issue 1981043004: Added the --screenshot option. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | build/android/pylib/local/device/local_device_instrumentation_test_run.py » ('j') | build/android/pylib/local/device/local_device_instrumentation_test_run.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: build/android/pylib/instrumentation/instrumentation_test_instance.py

diff --git a/build/android/pylib/instrumentation/instrumentation_test_instance.py b/build/android/pylib/instrumentation/instrumentation_test_instance.py

index 610f084ba054b787488f49cc00ef860143db3396..9145a7b72a2d05d3c229739aef1e0a4997c63a37 100644

--- a/build/android/pylib/instrumentation/instrumentation_test_instance.py

+++ b/build/android/pylib/instrumentation/instrumentation_test_instance.py

@@ -387,6 +387,7 @@ class InstrumentationTestInstance(test_instance.TestInstance):

def _initializeTestControlAttributes(self, args):

self._timeout_scale = args.timeout_scale or 1

+ self._screenshot_failures = args.screenshot_failures

jbudorick 2016/05/17 00:01:16 nit: alphabetize

BigBossZhiling 2016/05/18 17:46:11 Done.

@property

def additional_apks(self):

@@ -452,6 +453,10 @@ class InstrumentationTestInstance(test_instance.TestInstance):

def timeout_scale(self):

return self._timeout_scale

+ @property

+ def screenshot_failures(self):

jbudorick 2016/05/17 00:01:16 nit: alphabetize

BigBossZhiling 2016/05/18 17:46:11 Done.

+ return self._screenshot_failures

#override

def TestType(self):

return 'instrumentation'