Omnibox Logging: Record Whether User Was on a Search Result Page

chrome/browser/ui/omnibox/omnibox_edit_model.cc

Index: chrome/browser/ui/omnibox/omnibox_edit_model.cc
diff --git a/chrome/browser/ui/omnibox/omnibox_edit_model.cc b/chrome/browser/ui/omnibox/omnibox_edit_model.cc
index 6b54a7224754bdc202a6787aff456018ed6cb44f..2a03a2a427191cfa8b6e7788682c08558c374582 100644
--- a/chrome/browser/ui/omnibox/omnibox_edit_model.cc
+++ b/chrome/browser/ui/omnibox/omnibox_edit_model.cc
@@ -1280,6 +1280,10 @@ metrics::OmniboxEventProto::PageClassification
     return metrics::OmniboxEventProto_PageClassification_BLANK;
   if (url == profile()->GetPrefs()->GetString(prefs::kHomePage))
     return metrics::OmniboxEventProto_PageClassification_HOMEPAGE;
+  if (view_->toolbar_model()->WouldReplaceSearchURLWithSearchTerms(true)) {
+    return metrics::
+        OmniboxEventProto_PageClassification_SEARCH_RESULT_PAGE_DOING_SEARCH_TERM_REPLACEMENT;

[Ilya Sherman, 2013/07/19 21:06:34]

nit: I think you can refer to this as
metrics::OmniboxEventProto::SEARCH_RESULT_PAGE_DOING_SEARCH_TER
      M_REPLACEMENT; or something like that, so that the wrapping can look
nicer.

[Mark P, 2013/07/19 21:40:22]

Yup, that works.  Done.  Also changed (for consistency) the other references in
this function to be this format.

+  }
   return metrics::OmniboxEventProto_PageClassification_OTHER;
 }