Omnibox Logging: Record Whether User Was on a Search Result Page

chrome/browser/ui/omnibox/omnibox_edit_model.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/omnibox/omnibox_edit_model.h"
 
 #include <string>
 
 #include "base/auto_reset.h"
 #include "base/format_macros.h"
@@ skipping 1262 matching lines @@
   const GURL& gurl = delegate_->GetURL();
   if (!gurl.is_valid())
     return metrics::OmniboxEventProto_PageClassification_INVALID_SPEC;
   const std::string& url = gurl.spec();
   if (url == chrome::kChromeUINewTabURL)
     return metrics::OmniboxEventProto_PageClassification_NEW_TAB_PAGE;
   if (url == content::kAboutBlankURL)
     return metrics::OmniboxEventProto_PageClassification_BLANK;
   if (url == profile()->GetPrefs()->GetString(prefs::kHomePage))
     return metrics::OmniboxEventProto_PageClassification_HOMEPAGE;
+  if (view_->toolbar_model()->WouldReplaceSearchURLWithSearchTerms(true)) {
+    return metrics::
+        OmniboxEventProto_PageClassification_SEARCH_RESULT_PAGE_DOING_SEARCH_TERM_REPLACEMENT;

[Ilya Sherman, 2013/07/19 21:06:34]

nit: I think you can refer to this as
metrics::OmniboxEventProto::SEARCH_RESULT_PAGE_DOING_SEARCH_TER
      M_REPLACEMENT; or something like that, so that the wrapping can look
nicer.

[Mark P, 2013/07/19 21:40:22]

Yup, that works.  Done.  Also changed (for consistency) the other references in
this function to be this format.

+  }
   return metrics::OmniboxEventProto_PageClassification_OTHER;
 }
 
 void OmniboxEditModel::ClassifyStringForPasteAndGo(
     const string16& text,
     AutocompleteMatch* match,
     GURL* alternate_nav_url) const {
   DCHECK(match);
   AutocompleteClassifierFactory::GetForProfile(profile_)->Classify(text,
       false, false, match, alternate_nav_url);
 }
 
 void OmniboxEditModel::SetFocusState(OmniboxFocusState state,
                                      OmniboxFocusChangeReason reason) {
   if (state == focus_state_)
     return;
 
   InstantController* instant = GetInstantController();
   if (instant)
     instant->OmniboxFocusChanged(state, reason, NULL);
 
   // Update state and notify view if the omnibox has focus and the caret
   // visibility changed.
   const bool was_caret_visible = is_caret_visible();
   focus_state_ = state;
   if (focus_state_ != OMNIBOX_FOCUS_NONE &&
       is_caret_visible() != was_caret_visible)
     view_->ApplyCaretVisibility();
 }