Omnibox Logging: Record Whether User Was on a Search Result Page

Omnibox Logging: Record Whether User Was on a Search Result Page

More precisely, reduce whether the user was on a search result page
doing search term replacement.

This has been approved by chrome-privacy.

Tested by adding a LOG(INFO) line in metrics_log to see what the page 
classification emitted was.

BUG=251484
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212895

[Mark P, 2013-07-19 14:39:28]

Simple and easy.  Sorry I couldn't do anything about the spacing.  (No, I don't
want to abbreviate the enum; I have using the term SRP because lots of people
don't know immediately know what it means.)

--mark

[Peter Kasting, 2013-07-19 20:51:25]

LGTM

[Ilya Sherman, 2013-07-19 21:06:33]

Drive-by nit:

https://codereview.chromium.org/19810002/diff/1/chrome/browser/ui/omnibox/omn...
File chrome/browser/ui/omnibox/omnibox_edit_model.cc (right):

https://codereview.chromium.org/19810002/diff/1/chrome/browser/ui/omnibox/omn...
chrome/browser/ui/omnibox/omnibox_edit_model.cc:1285:
OmniboxEventProto_PageClassification_SEARCH_RESULT_PAGE_DOING_SEARCH_TERM_REPLACEMENT;
nit: I think you can refer to this as
metrics::OmniboxEventProto::SEARCH_RESULT_PAGE_DOING_SEARCH_TER
      M_REPLACEMENT; or something like that, so that the wrapping can look
nicer.

[Mark P, 2013-07-19 21:40:22]

https://codereview.chromium.org/19810002/diff/1/chrome/browser/ui/omnibox/omn...
File chrome/browser/ui/omnibox/omnibox_edit_model.cc (right):

https://codereview.chromium.org/19810002/diff/1/chrome/browser/ui/omnibox/omn...
chrome/browser/ui/omnibox/omnibox_edit_model.cc:1285:
OmniboxEventProto_PageClassification_SEARCH_RESULT_PAGE_DOING_SEARCH_TERM_REPLACEMENT;
On 2013/07/19 21:06:34, Ilya Sherman wrote:
> nit: I think you can refer to this as
> metrics::OmniboxEventProto::SEARCH_RESULT_PAGE_DOING_SEARCH_TER
>       M_REPLACEMENT; or something like that, so that the wrapping can look
> nicer.

Yup, that works.  Done.  Also changed (for consistency) the other references in
this function to be this format.

[Mark P, 2013-07-21 19:43:20]

The server change has been submitted.

Submitted this client code change now.

--mark

[commit-bot: I haz the power, 2013-07-21 19:44:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mpearson@chromium.org/19810002/7001

[commit-bot: I haz the power, 2013-07-21 23:17:51]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-07-22 01:08:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mpearson@chromium.org/19810002/7001

[commit-bot: I haz the power, 2013-07-22 03:47:13]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-07-22 15:31:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mpearson@chromium.org/19810002/7001

[commit-bot: I haz the power, 2013-07-22 16:18:00]

Change committed as 212895