Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1980983002: DevTools: use script fetch time instead of last modified time for service workers. (Closed)

Created:
4 years, 7 months ago by pfeldman
Modified:
4 years, 7 months ago
Reviewers:
paulirish
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: use script fetch time instead of last modified time for service workers. BUG=612011 Committed: https://crrev.com/176f8dda3c4d56032885fc6936c384115e1f5f9b Cr-Commit-Position: refs/heads/master@{#393918}

Patch Set 1 #

Patch Set 2 : fixed the patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-test.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-view-expected.txt View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
pfeldman
4 years, 7 months ago (2016-05-16 18:40:07 UTC) #2
paulirish
lgtm
4 years, 7 months ago (2016-05-16 18:45:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1980983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1980983002/1
4 years, 7 months ago (2016-05-16 18:46:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1980983002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1980983002/20001
4 years, 7 months ago (2016-05-16 18:48:37 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-16 21:10:04 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-16 21:12:14 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/176f8dda3c4d56032885fc6936c384115e1f5f9b
Cr-Commit-Position: refs/heads/master@{#393918}

Powered by Google App Engine
This is Rietveld 408576698