Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Unified Diff: third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js

Issue 1980983002: DevTools: use script fetch time instead of last modified time for service workers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed the patch Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-view-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js b/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js
index 94d329907db07135b22c06b30942bef74c5044dd..de5912c60d70e5dfda9e05d30fd6305112e61a80 100644
--- a/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js
+++ b/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js
@@ -205,7 +205,7 @@ WebInspector.ServiceWorkersView.Section.prototype = {
scriptElement.removeChildren();
var fileName = WebInspector.ParsedURL.extractName(active.scriptURL);
scriptElement.appendChild(WebInspector.linkifyURLAsNode(active.scriptURL, fileName));
- scriptElement.createChild("div", "report-field-value-subtitle").textContent = WebInspector.UIString("Last modified %s", new Date(active.scriptLastModified * 1000).toLocaleString());
+ scriptElement.createChild("div", "report-field-value-subtitle").textContent = WebInspector.UIString("Received %s", new Date(active.scriptResponseTime * 1000).toLocaleString());
var activeEntry = versionsStack.createChild("div", "service-worker-version");
activeEntry.createChild("div", "service-worker-active-circle");
@@ -235,7 +235,7 @@ WebInspector.ServiceWorkersView.Section.prototype = {
waitingEntry.createChild("div", "service-worker-waiting-circle");
waitingEntry.createChild("span").textContent = WebInspector.UIString("#%s waiting to activate", waiting.id);
createLink(waitingEntry, WebInspector.UIString("skipWaiting"), this._skipButtonClicked.bind(this));
- waitingEntry.createChild("div", "service-worker-subtitle").textContent = new Date(waiting.scriptLastModified * 1000).toLocaleString();
+ waitingEntry.createChild("div", "service-worker-subtitle").textContent = new Date(waiting.scriptResponseTime * 1000).toLocaleString();
if (!this._manager.targetForVersionId(waiting.id) && (waiting.isRunning() || waiting.isStarting()))
createLink(waitingEntry, WebInspector.UIString("inspect"), this._inspectButtonClicked.bind(this, waiting.id));
}
@@ -243,7 +243,7 @@ WebInspector.ServiceWorkersView.Section.prototype = {
var installingEntry = versionsStack.createChild("div", "service-worker-version");
installingEntry.createChild("div", "service-worker-installing-circle");
installingEntry.createChild("span").textContent = WebInspector.UIString("#%s installing", installing.id);
- installingEntry.createChild("div", "service-worker-subtitle").textContent = new Date(installing.scriptLastModified * 1000).toLocaleString();
+ installingEntry.createChild("div", "service-worker-subtitle").textContent = new Date(installing.scriptResponseTime * 1000).toLocaleString();
if (!this._manager.targetForVersionId(installing.id) && (installing.isRunning() || installing.isStarting()))
createLink(installingEntry, WebInspector.UIString("inspect"), this._inspectButtonClicked.bind(this, installing.id));
}
« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-view-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698