Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1980883002: Revert of QUIC - enable "delay_tcp_race" parameter by default. This feature showed (Closed)

Created:
4 years, 7 months ago by ramant (doing other things)
Modified:
4 years, 7 months ago
Reviewers:
Ryan Hamilton, xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of QUIC - enable "delay_tcp_race" parameter by default. This feature showed (patchset #3 id:60001 of https://codereview.chromium.org/1916783003/ ) Reason for revert: Reverting this CL so that we could experiment delay_tcp_race. Original issue's description: > QUIC - enable "delay_tcp_race" parameter by default. This feature showed > positive results in stable channel and it will be enabled by default > via finch trial in Stable and Beta (M50 and M51). > > R=rch@chromium.org,xunjieli@chromium.org > > Committed: https://crrev.com/634050c3f304a48f62c6ceb022a7f83945ea1968 > Cr-Commit-Position: refs/heads/master@{#390468} TBR=rch@chromium.org,xunjieli@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -11 lines) Patch
M chrome/browser/io_thread.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/io_thread.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/io_thread_unittest.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java View 1 chunk +1 line, -0 lines 0 comments Download
M components/cronet/url_request_context_config.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M components/cronet/url_request_context_config_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/ios_chrome_io_thread.h View 2 chunks +5 lines, -0 lines 0 comments Download
M ios/chrome/browser/ios_chrome_io_thread.mm View 3 chunks +8 lines, -0 lines 0 comments Download
M net/http/http_network_session.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/http/http_network_session.cc View 3 chunks +3 lines, -1 line 0 comments Download
M net/http/http_stream_factory_impl_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/quic_network_transaction_unittest.cc View 24 chunks +55 lines, -6 lines 0 comments Download
M net/quic/quic_stream_factory.h View 3 chunks +6 lines, -0 lines 0 comments Download
M net/quic/quic_stream_factory.cc View 3 chunks +3 lines, -1 line 0 comments Download
M net/quic/quic_stream_factory_test.cc View 6 chunks +14 lines, -1 line 0 comments Download
M net/quic/test_tools/quic_stream_factory_peer.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_stream_factory_peer.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M net/url_request/url_request_context_builder.h View 2 chunks +5 lines, -0 lines 0 comments Download
M net/url_request/url_request_context_builder.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ramant (doing other things)
Created Revert of QUIC - enable "delay_tcp_race" parameter by default. This feature showed
4 years, 7 months ago (2016-05-15 22:10:47 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1980883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1980883002/1
4 years, 7 months ago (2016-05-15 22:11:57 UTC) #3
Ryan Hamilton
lgtm, though I thought we still wanted to make delay_tcp_race the default.
4 years, 7 months ago (2016-05-15 22:12:14 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/5799) ios-device-gn on ...
4 years, 7 months ago (2016-05-15 22:13:47 UTC) #6
ramant (doing other things)
On 2016/05/15 22:12:14, Ryan Hamilton wrote: > lgtm, though I thought we still wanted to ...
4 years, 7 months ago (2016-05-15 22:17:33 UTC) #7
ramant (doing other things)
4 years, 7 months ago (2016-05-15 22:38:28 UTC) #8
On 2016/05/15 22:17:33, ramant wrote:
> On 2016/05/15 22:12:14, Ryan Hamilton wrote:
> > lgtm, though I thought we still wanted to make delay_tcp_race the default.
> 
> Hi Ryan,
>   Will submit another CL which makes delay_tcp_race as the default after this
CL
> lands.
> 
>   I had the following CL (which enabled delay_tcp_race as well as reverted). 
>   Thought if I do revert first and then add back code that makes
delay_tcp_race
> as
>   the default, it may make it easier to review.
> 
>      https://codereview.chromium.org/1973403002/
> 
> thanks
> raman

Abandoning this CL because "Revert Patchset" wasn't able to revert changes
to net/quic/quic_network_transaction_unittest.cc. Reverted the changes to 
this file manually in https://codereview.chromium.org/1977303002/

Powered by Google App Engine
This is Rietveld 408576698