Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(818)

Side by Side Diff: ios/chrome/browser/ios_chrome_io_thread.mm

Issue 1980883002: Revert of QUIC - enable "delay_tcp_race" parameter by default. This feature showed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ios/chrome/browser/ios_chrome_io_thread.h ('k') | net/http/http_network_session.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ios/chrome/browser/ios_chrome_io_thread.h" 5 #include "ios/chrome/browser/ios_chrome_io_thread.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <utility> 9 #include <utility>
10 #include <vector> 10 #include <vector>
(...skipping 646 matching lines...) Expand 10 before | Expand all | Expand 10 after
657 globals.quic_enable_non_blocking_io.CopyToIfSet( 657 globals.quic_enable_non_blocking_io.CopyToIfSet(
658 &params->quic_enable_non_blocking_io); 658 &params->quic_enable_non_blocking_io);
659 globals.quic_prefer_aes.CopyToIfSet(&params->quic_prefer_aes); 659 globals.quic_prefer_aes.CopyToIfSet(&params->quic_prefer_aes);
660 globals.quic_disable_disk_cache.CopyToIfSet(&params->quic_disable_disk_cache); 660 globals.quic_disable_disk_cache.CopyToIfSet(&params->quic_disable_disk_cache);
661 globals.quic_max_number_of_lossy_connections.CopyToIfSet( 661 globals.quic_max_number_of_lossy_connections.CopyToIfSet(
662 &params->quic_max_number_of_lossy_connections); 662 &params->quic_max_number_of_lossy_connections);
663 globals.quic_packet_loss_threshold.CopyToIfSet( 663 globals.quic_packet_loss_threshold.CopyToIfSet(
664 &params->quic_packet_loss_threshold); 664 &params->quic_packet_loss_threshold);
665 globals.quic_socket_receive_buffer_size.CopyToIfSet( 665 globals.quic_socket_receive_buffer_size.CopyToIfSet(
666 &params->quic_socket_receive_buffer_size); 666 &params->quic_socket_receive_buffer_size);
667 globals.quic_delay_tcp_race.CopyToIfSet(&params->quic_delay_tcp_race);
667 params->enable_quic_port_selection = false; 668 params->enable_quic_port_selection = false;
668 globals.quic_max_packet_length.CopyToIfSet(&params->quic_max_packet_length); 669 globals.quic_max_packet_length.CopyToIfSet(&params->quic_max_packet_length);
669 globals.quic_user_agent_id.CopyToIfSet(&params->quic_user_agent_id); 670 globals.quic_user_agent_id.CopyToIfSet(&params->quic_user_agent_id);
670 globals.quic_supported_versions.CopyToIfSet(&params->quic_supported_versions); 671 globals.quic_supported_versions.CopyToIfSet(&params->quic_supported_versions);
671 params->quic_connection_options = globals.quic_connection_options; 672 params->quic_connection_options = globals.quic_connection_options;
672 globals.quic_close_sessions_on_ip_change.CopyToIfSet( 673 globals.quic_close_sessions_on_ip_change.CopyToIfSet(
673 &params->quic_close_sessions_on_ip_change); 674 &params->quic_close_sessions_on_ip_change);
674 675
675 params->enable_user_alternate_protocol_ports = false; 676 params->enable_user_alternate_protocol_ports = false;
676 } 677 }
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
764 765
765 if (enable_quic) { 766 if (enable_quic) {
766 globals->quic_always_require_handshake_confirmation.set( 767 globals->quic_always_require_handshake_confirmation.set(
767 ShouldQuicAlwaysRequireHandshakeConfirmation(quic_trial_params)); 768 ShouldQuicAlwaysRequireHandshakeConfirmation(quic_trial_params));
768 globals->quic_disable_connection_pooling.set( 769 globals->quic_disable_connection_pooling.set(
769 ShouldQuicDisableConnectionPooling(quic_trial_params)); 770 ShouldQuicDisableConnectionPooling(quic_trial_params));
770 int receive_buffer_size = GetQuicSocketReceiveBufferSize(quic_trial_params); 771 int receive_buffer_size = GetQuicSocketReceiveBufferSize(quic_trial_params);
771 if (receive_buffer_size != 0) { 772 if (receive_buffer_size != 0) {
772 globals->quic_socket_receive_buffer_size.set(receive_buffer_size); 773 globals->quic_socket_receive_buffer_size.set(receive_buffer_size);
773 } 774 }
775 globals->quic_delay_tcp_race.set(ShouldQuicDelayTcpRace(quic_trial_params));
774 float load_server_info_timeout_srtt_multiplier = 776 float load_server_info_timeout_srtt_multiplier =
775 GetQuicLoadServerInfoTimeoutSrttMultiplier(quic_trial_params); 777 GetQuicLoadServerInfoTimeoutSrttMultiplier(quic_trial_params);
776 if (load_server_info_timeout_srtt_multiplier != 0) { 778 if (load_server_info_timeout_srtt_multiplier != 0) {
777 globals->quic_load_server_info_timeout_srtt_multiplier.set( 779 globals->quic_load_server_info_timeout_srtt_multiplier.set(
778 load_server_info_timeout_srtt_multiplier); 780 load_server_info_timeout_srtt_multiplier);
779 } 781 }
780 globals->quic_enable_connection_racing.set( 782 globals->quic_enable_connection_racing.set(
781 ShouldQuicEnableConnectionRacing(quic_trial_params)); 783 ShouldQuicEnableConnectionRacing(quic_trial_params));
782 globals->quic_enable_non_blocking_io.set( 784 globals->quic_enable_non_blocking_io.set(
783 ShouldQuicEnableNonBlockingIO(quic_trial_params)); 785 ShouldQuicEnableNonBlockingIO(quic_trial_params));
(...skipping 152 matching lines...) Expand 10 before | Expand all | Expand 10 after
936 const VariationParameters& quic_trial_params) { 938 const VariationParameters& quic_trial_params) {
937 int value; 939 int value;
938 if (base::StringToInt( 940 if (base::StringToInt(
939 GetVariationParam(quic_trial_params, "receive_buffer_size"), 941 GetVariationParam(quic_trial_params, "receive_buffer_size"),
940 &value)) { 942 &value)) {
941 return value; 943 return value;
942 } 944 }
943 return 0; 945 return 0;
944 } 946 }
945 947
948 bool IOSChromeIOThread::ShouldQuicDelayTcpRace(
949 const VariationParameters& quic_trial_params) {
950 return base::LowerCaseEqualsASCII(
951 GetVariationParam(quic_trial_params, "delay_tcp_race"), "true");
952 }
953
946 bool IOSChromeIOThread::ShouldQuicCloseSessionsOnIpChange( 954 bool IOSChromeIOThread::ShouldQuicCloseSessionsOnIpChange(
947 const VariationParameters& quic_trial_params) { 955 const VariationParameters& quic_trial_params) {
948 return base::LowerCaseEqualsASCII( 956 return base::LowerCaseEqualsASCII(
949 GetVariationParam(quic_trial_params, "close_sessions_on_ip_change"), 957 GetVariationParam(quic_trial_params, "close_sessions_on_ip_change"),
950 "true"); 958 "true");
951 } 959 }
952 960
953 size_t IOSChromeIOThread::GetQuicMaxPacketLength( 961 size_t IOSChromeIOThread::GetQuicMaxPacketLength(
954 const VariationParameters& quic_trial_params) { 962 const VariationParameters& quic_trial_params) {
955 unsigned value; 963 unsigned value;
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
1023 1031
1024 globals->system_http_network_session.reset( 1032 globals->system_http_network_session.reset(
1025 new net::HttpNetworkSession(system_params)); 1033 new net::HttpNetworkSession(system_params));
1026 globals->system_http_transaction_factory.reset( 1034 globals->system_http_transaction_factory.reset(
1027 new net::HttpNetworkLayer(globals->system_http_network_session.get())); 1035 new net::HttpNetworkLayer(globals->system_http_network_session.get()));
1028 context->set_http_transaction_factory( 1036 context->set_http_transaction_factory(
1029 globals->system_http_transaction_factory.get()); 1037 globals->system_http_transaction_factory.get());
1030 1038
1031 return context; 1039 return context;
1032 } 1040 }
OLDNEW
« no previous file with comments | « ios/chrome/browser/ios_chrome_io_thread.h ('k') | net/http/http_network_session.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698