Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Unified Diff: components/nacl/browser/nacl_process_host.h

Issue 198083006: Update the task manager with the debug stub port chosen by nacl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/nacl/browser/nacl_process_host.h
diff --git a/components/nacl/browser/nacl_process_host.h b/components/nacl/browser/nacl_process_host.h
index 758f7080a4afe56d71eccc2c9c45dd99d28d6b49..2c20dad4a30699d19e6153c53be7b9153fd049b7 100644
--- a/components/nacl/browser/nacl_process_host.h
+++ b/components/nacl/browser/nacl_process_host.h
@@ -133,6 +133,10 @@ class NaClProcessHost : public content::BrowserChildProcessHostDelegate {
void SendMessageToRenderer(const NaClLaunchResult& result,
const std::string& error_message);
+ // Mark the process as using a particular debug stub port and notify
Mark Seaborn 2014/03/26 23:34:04 Nit: if you say "GDB debug stub" in the comments i
bradn 2014/05/05 18:46:07 Done.
+ // listeners.
+ void ChangeDebugStubPort(int port);
Mark Seaborn 2014/03/26 23:34:04 uint16_t for consistency with other cases? Maybe
bradn 2014/05/05 18:46:07 Done.
+
// Sends the message to the NaCl process to load the plugin. Returns true
// on success.
bool StartNaClExecution();
@@ -160,6 +164,9 @@ class NaClProcessHost : public content::BrowserChildProcessHostDelegate {
IPC::Message* reply_msg);
#endif
+ // Called when the debug stub port has be selected.
Mark Seaborn 2014/03/26 23:34:04 "has been"
bradn 2014/05/05 18:46:07 Done.
+ void OnDebugStubPortSelected(uint16_t debug_stub_port);
Mark Seaborn 2014/03/26 23:34:04 Nit: Can you keep the decl ordering the same as in
bradn 2014/05/05 18:46:07 Done.
+
// Called when the PPAPI IPC channels to the browser/renderer have been
// created.
void OnPpapiChannelsCreated(
« no previous file with comments | « no previous file | components/nacl/browser/nacl_process_host.cc » ('j') | components/nacl/browser/nacl_process_host.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698