Update the task manager with the debug stub port chosen by nacl.

components/nacl/browser/nacl_process_host.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_NACL_BROWSER_NACL_PROCESS_HOST_H_
 #define COMPONENTS_NACL_BROWSER_NACL_PROCESS_HOST_H_
 
 #include "build/build_config.h"
 
 #include "base/files/file_path.h"
@@ skipping 115 matching lines @@
                        const IPC::ChannelHandle& trusted_channel_handle);
 
   // Sends the reply with error message to the renderer.
   void SendErrorToRenderer(const std::string& error_message);
 
   // Sends the reply message to the renderer. Either result or
   // error message must be empty.
   void SendMessageToRenderer(const NaClLaunchResult& result,
                              const std::string& error_message);
 
+  // Mark the process as using a particular debug stub port and notify

[Mark Seaborn, 2014/03/26 23:34:04]

Nit: if you say "GDB debug stub" in the comments it provides a little more
context to unfamiliar readers.

[bradn, 2014/05/05 18:46:07]

Done.

+  // listeners.
+  void ChangeDebugStubPort(int port);

[Mark Seaborn, 2014/03/26 23:34:04]

uint16_t for consistency with other cases?  Maybe s/Change/Set/?

[bradn, 2014/05/05 18:46:07]

Done.

+
   // Sends the message to the NaCl process to load the plugin. Returns true
   // on success.
   bool StartNaClExecution();
 
   // Does post-process-launching tasks for starting the NaCl process once
   // we have a connection.
   //
   // Returns false on failure.
   bool StartWithLaunchedProcess();
 
   // Message handlers for validation caching.
   void OnQueryKnownToValidate(const std::string& signature, bool* result);
   void OnSetKnownToValidate(const std::string& signature);
   void OnResolveFileToken(uint64 file_token_lo, uint64 file_token_hi,
                           IPC::Message* reply_msg);
   void FileResolved(const base::FilePath& file_path,
                     IPC::Message* reply_msg,
                     base::File file);
 
 #if defined(OS_WIN)
   // Message handler for Windows hardware exception handling.
   void OnAttachDebugExceptionHandler(const std::string& info,
                                      IPC::Message* reply_msg);
   bool AttachDebugExceptionHandler(const std::string& info,
                                    IPC::Message* reply_msg);
 #endif
 
+  // Called when the debug stub port has be selected.

[Mark Seaborn, 2014/03/26 23:34:04]

"has been"

[bradn, 2014/05/05 18:46:07]

Done.

+  void OnDebugStubPortSelected(uint16_t debug_stub_port);

[Mark Seaborn, 2014/03/26 23:34:04]

Nit: Can you keep the decl ordering the same as in the .cc file?  Same for
ChangeDebugStubPort().

[bradn, 2014/05/05 18:46:07]

Done.

+
   // Called when the PPAPI IPC channels to the browser/renderer have been
   // created.
   void OnPpapiChannelsCreated(
       const IPC::ChannelHandle& browser_channel_handle,
       const IPC::ChannelHandle& ppapi_renderer_channel_handle,
       const IPC::ChannelHandle& trusted_renderer_channel_handle);
 
   GURL manifest_url_;
   ppapi::PpapiPermissions permissions_;
 
@@ skipping 44 matching lines @@
   scoped_ptr<content::BrowserPpapiHost> ppapi_host_;
 
   int render_view_id_;
 
   DISALLOW_COPY_AND_ASSIGN(NaClProcessHost);
 };
 
 }  // namespace nacl
 
 #endif  // COMPONENTS_NACL_BROWSER_NACL_PROCESS_HOST_H_