Clear knownToHaveNoOverflow() for line boxes when recomputing overflow without layout

Clear knownToHaveNoOverflow() for line boxes when recomputing overflow without layout

knownToHaveNoOverflow() typically gets reset during layout. When we're just
recomputing overflow without a layout we have to clear it ourselves on any
lineboxes that we identify as needing overflow recalculated, otherwise computeOverflow()
on the linebox returns early.

BUG=609414
Committed: https://crrev.com/ed8035039a5d5a4424ae8f11d80d7b20ebb92537
Cr-Commit-Position: refs/heads/master@{#394186}

[rhogan, 2016-05-15 10:36:54]

robhogan@gmail.com changed reviewers:
+ wangxianzhu@chromium.org

[Xianzhu, 2016-05-16 22:29:19]

Please update the title and description to state that this CL ensures
clearKnownToHaveNoOverflow() when recomputing line box overflow without layout.

https://codereview.chromium.org/1980733002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp (right):

https://codereview.chromium.org/1980733002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp:3179:
box->clearKnownToHaveNoOverflow();
Shouldn't we clearKnownToHaveNoOverflow() in computeOverflow()?

[rhogan, 2016-05-17 17:38:08]

https://codereview.chromium.org/1980733002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp (right):

https://codereview.chromium.org/1980733002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp:3179:
box->clearKnownToHaveNoOverflow();
On 2016/05/16 at 22:29:19, Xianzhu wrote:
> Shouldn't we clearKnownToHaveNoOverflow() in computeOverflow()?

No, because InlineBox::computeOverflow() consults noKnownOverflow().

[rhogan, 2016-05-17 17:39:08]

Description was changed from

==========
Clip visual overflow from line boxes when recomputing overflow without layout

BUG=609414
==========

to

==========
Clear noKnownOverflow() for line boxes when recomputing overflow without layout



BUG=609414
==========

[rhogan, 2016-05-17 17:43:02]

Description was changed from

==========
Clear noKnownOverflow() for line boxes when recomputing overflow without layout



BUG=609414
==========

to

==========
Clear knownToHaveNoOverflow() for line boxes when recomputing overflow without
layout

knownToHaveNoOverflow() typically gets reset during layout. When we're just
recomputing overflow without a layout we have to clear it ourselves on any
lineboxes that we identify as needing overflow recalculated, otherwise
computeOverflow()
on the linebox returns early.

BUG=609414
==========

[Xianzhu, 2016-05-17 17:45:00]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-05-17 17:45:01]

lgtm

[commit-bot: I haz the power, 2016-05-17 17:45:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1980733002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1980733002/1

[commit-bot: I haz the power, 2016-05-17 19:23:04]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-17 19:25:56]

Description was changed from

==========
Clear knownToHaveNoOverflow() for line boxes when recomputing overflow without
layout

knownToHaveNoOverflow() typically gets reset during layout. When we're just
recomputing overflow without a layout we have to clear it ourselves on any
lineboxes that we identify as needing overflow recalculated, otherwise
computeOverflow()
on the linebox returns early.

BUG=609414
==========

to

==========
Clear knownToHaveNoOverflow() for line boxes when recomputing overflow without
layout

knownToHaveNoOverflow() typically gets reset during layout. When we're just
recomputing overflow without a layout we have to clear it ourselves on any
lineboxes that we identify as needing overflow recalculated, otherwise
computeOverflow()
on the linebox returns early.

BUG=609414

Committed: https://crrev.com/ed8035039a5d5a4424ae8f11d80d7b20ebb92537
Cr-Commit-Position: refs/heads/master@{#394186}
==========

[commit-bot: I haz the power, 2016-05-17 19:25:57]

Patchset 1 (id:??) landed as
https://crrev.com/ed8035039a5d5a4424ae8f11d80d7b20ebb92537
Cr-Commit-Position: refs/heads/master@{#394186}