third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp - Issue 1980733002: Clear knownToHaveNoOverflow() for line boxes when recomputing overflow without layout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp

Issue 1980733002: Clear knownToHaveNoOverflow() for line boxes when recomputing overflow without layout (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp b/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp

index 6fbbd92cb6f4ded212c91d621f5a3b97f3963136..d74195b64d1ca2383f6c5be485439b868c258d38 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp

@@ -3176,6 +3176,7 @@ bool LayoutBlockFlow::recalcInlineChildrenOverflowAfterStyleChange()

GlyphOverflowAndFallbackFontsMap textBoxDataMap;

for (ListHashSet<RootInlineBox*>::const_iterator it = lineBoxes.begin(); it != lineBoxes.end(); ++it) {

RootInlineBox* box = *it;

+ box->clearKnownToHaveNoOverflow();

Xianzhu 2016/05/16 22:29:19 Shouldn't we clearKnownToHaveNoOverflow() in compu

rhogan 2016/05/17 17:38:08 No, because InlineBox::computeOverflow() consults

box->computeOverflow(box->lineTop(), box->lineBottom(), textBoxDataMap);

}

return childrenOverflowChanged;

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/repaint/inline-box-overflow-repaint-expected.html ('k') | no next file » | no next file with comments »