Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: tools/ToolUtils.h

Issue 19807005: refactor duplication (shouldSkip and skip_name) into a utility function (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: Forgot to add new files.. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/skia_test.cpp ('k') | tools/ToolUtils.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/ToolUtils.h
diff --git a/tools/ToolUtils.h b/tools/ToolUtils.h
new file mode 100644
index 0000000000000000000000000000000000000000..445d69e91d8d7a57ca4c63618053ca938a2526cb
--- /dev/null
+++ b/tools/ToolUtils.h
@@ -0,0 +1,15 @@
+#ifndef ToolUtils_DEFINED
+#define ToolUtils_DEFINED
+
+#include "SkTDArray.h"
+
+/* Takes a list of the form [~][^]match[$]
+ ~ causes a matching test to always be skipped
+ ^ requires the start of the test to match
+ $ requires the end of the test to match
+ ^ and $ requires an exact match
+ If a test does not match any list entry, it is skipped unless some list entry starts with ~
+ */
+bool shouldSkip(const SkTDArray<const char*>& strings, const char* name);
reed1 2013/07/23 14:01:40 1. This file name is slightly odd, in that it has
+
+#endif
« no previous file with comments | « tests/skia_test.cpp ('k') | tools/ToolUtils.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698