tools/ToolUtils.h - Issue 19807005: refactor duplication (shouldSkip and skip_name) into a utility function

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/ToolUtils.h

Issue 19807005: refactor duplication (shouldSkip and skip_name) into a utility function (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Forgot to add new files.. Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 #ifndef ToolUtils_DEFINED

	2 #define ToolUtils_DEFINED

	3

	4 #include "SkTDArray.h"

	5

	6 /* Takes a list of the form [~][^]match[$]

	7 ~ causes a matching test to always be skipped

	8 ^ requires the start of the test to match

	9 $ requires the end of the test to match

	10 ^ and $ requires an exact match

	11 If a test does not match any list entry, it is skipped unless some list entry starts with ~

	12 */

	13 bool shouldSkip(const SkTDArray<const char>& strings, const char name);
	reed1 2013/07/23 14:01:40 1. This file name is slightly odd, in that it has 1. This file name is slightly odd, in that it has no Sk 2. This function is poorly scoped: no sk, no class wrapper 3. Is there really no existing .h we can add this one function to?
	14

	15 #endif

OLD	NEW

« no previous file with comments | « tests/skia_test.cpp ('k') | tools/ToolUtils.cpp » ('j') | no next file with comments »