Make ResourceResponse's cached CacheControlHeader mutable.

Make ResourceResponse's cached CacheControlHeader mutable.

This allows a variety of accessor methods to be called even on const
ResourceResponse objects:

cacheControlContainsNoCache()
cacheControlContainsNoStore()
cacheControlContainsMustRevalidate()
cacheControlMaxAge()
cacheControlStaleWhileRevalidate()

Making this mutable doesn't affect the const semantics of the
ResourceRequest.  Also note that this field is already
mutable on ResourceResponse.

BUG=

Committed: https://crrev.com/64b2852e18fbf675c524f1bd4911e5acb1643c8f
Cr-Commit-Position: refs/heads/master@{#393619}

[dewittj, 2016-05-13 18:33:01]

Description was changed from

==========
Make ResourceResponse's cached CacheControlHeader mutable.

This allows a variety of accessor methods to be called even on const
ResourceResponse objects:

cacheControlContainsNoCache()
cacheControlContainsNoStore()
cacheControlContainsMustRevalidate()
cacheControlMaxAge()
cacheControlStaleWhileRevalidate()

Making this mutable doesn't affect the const semantics of the
ResourceRequest.

BUG=
==========

to

==========
Make ResourceResponse's cached CacheControlHeader mutable.

This allows a variety of accessor methods to be called even on const
ResourceResponse objects:

cacheControlContainsNoCache()
cacheControlContainsNoStore()
cacheControlContainsMustRevalidate()
cacheControlMaxAge()
cacheControlStaleWhileRevalidate()

Making this mutable doesn't affect the const semantics of the
ResourceRequest.  Also note that this field is already
mutable on ResourceResponse.

BUG=
==========

[dewittj, 2016-05-13 18:33:01]

dewittj@chromium.org changed reviewers:
+ esprehn@chromium.org

[dewittj, 2016-05-13 18:33:27]

esprehn: PTAL, thanks.

[esprehn, 2016-05-13 18:39:39]

This should be done in tandem with code that needs it. is there a bug you're
working on?

[dewittj, 2016-05-13 19:13:41]

On 2016/05/13 18:39:39, esprehn wrote:
> This should be done in tandem with code that needs it. is there a bug you're
> working on?

This was suggested as part of https://codereview.chromium.org/1947263004/ but I
thought smaller patch would be better for you. I can integrate this over there
if you like.

[esprehn, 2016-05-13 19:23:14]

On 2016/05/13 at 19:13:41, dewittj wrote:
> On 2016/05/13 18:39:39, esprehn wrote:
> > This should be done in tandem with code that needs it. is there a bug you're
> > working on?
> 
> This was suggested as part of https://codereview.chromium.org/1947263004/ but
I thought smaller patch would be better for you. I can integrate this over there
if you like.

This patch lgtm, in the future mention where/why you're doing something in the
description for reviewers. :)

[dewittj, 2016-05-13 19:37:04]

Will do.  Thanks for your patience!

[dewittj, 2016-05-13 19:37:08]

The CQ bit was checked by dewittj@chromium.org

[commit-bot: I haz the power, 2016-05-13 19:37:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1980673002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1980673002/1

[commit-bot: I haz the power, 2016-05-13 20:37:40]

Description was changed from

==========
Make ResourceResponse's cached CacheControlHeader mutable.

This allows a variety of accessor methods to be called even on const
ResourceResponse objects:

cacheControlContainsNoCache()
cacheControlContainsNoStore()
cacheControlContainsMustRevalidate()
cacheControlMaxAge()
cacheControlStaleWhileRevalidate()

Making this mutable doesn't affect the const semantics of the
ResourceRequest.  Also note that this field is already
mutable on ResourceResponse.

BUG=
==========

to

==========
Make ResourceResponse's cached CacheControlHeader mutable.

This allows a variety of accessor methods to be called even on const
ResourceResponse objects:

cacheControlContainsNoCache()
cacheControlContainsNoStore()
cacheControlContainsMustRevalidate()
cacheControlMaxAge()
cacheControlStaleWhileRevalidate()

Making this mutable doesn't affect the const semantics of the
ResourceRequest.  Also note that this field is already
mutable on ResourceResponse.

BUG=
==========

[commit-bot: I haz the power, 2016-05-13 20:37:41]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-13 20:38:50]

Description was changed from

==========
Make ResourceResponse's cached CacheControlHeader mutable.

This allows a variety of accessor methods to be called even on const
ResourceResponse objects:

cacheControlContainsNoCache()
cacheControlContainsNoStore()
cacheControlContainsMustRevalidate()
cacheControlMaxAge()
cacheControlStaleWhileRevalidate()

Making this mutable doesn't affect the const semantics of the
ResourceRequest.  Also note that this field is already
mutable on ResourceResponse.

BUG=
==========

to

==========
Make ResourceResponse's cached CacheControlHeader mutable.

This allows a variety of accessor methods to be called even on const
ResourceResponse objects:

cacheControlContainsNoCache()
cacheControlContainsNoStore()
cacheControlContainsMustRevalidate()
cacheControlMaxAge()
cacheControlStaleWhileRevalidate()

Making this mutable doesn't affect the const semantics of the
ResourceRequest.  Also note that this field is already
mutable on ResourceResponse.

BUG=

Committed: https://crrev.com/64b2852e18fbf675c524f1bd4911e5acb1643c8f
Cr-Commit-Position: refs/heads/master@{#393619}
==========

[commit-bot: I haz the power, 2016-05-13 20:38:51]

Patchset 1 (id:??) landed as
https://crrev.com/64b2852e18fbf675c524f1bd4911e5acb1643c8f
Cr-Commit-Position: refs/heads/master@{#393619}