Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Side by Side Diff: third_party/WebKit/Source/platform/network/ResourceResponse.cpp

Issue 1980673002: Make ResourceResponse's cached CacheControlHeader mutable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/network/ResourceResponse.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2009 Google Inc. All rights reserved. 3 * Copyright (C) 2009 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 344 matching lines...) Expand 10 before | Expand all | Expand 10 after
355 void ResourceResponse::clearHTTPHeaderField(const AtomicString& name) 355 void ResourceResponse::clearHTTPHeaderField(const AtomicString& name)
356 { 356 {
357 m_httpHeaderFields.remove(name); 357 m_httpHeaderFields.remove(name);
358 } 358 }
359 359
360 const HTTPHeaderMap& ResourceResponse::httpHeaderFields() const 360 const HTTPHeaderMap& ResourceResponse::httpHeaderFields() const
361 { 361 {
362 return m_httpHeaderFields; 362 return m_httpHeaderFields;
363 } 363 }
364 364
365 bool ResourceResponse::cacheControlContainsNoCache() 365 bool ResourceResponse::cacheControlContainsNoCache() const
366 { 366 {
367 if (!m_cacheControlHeader.parsed) 367 if (!m_cacheControlHeader.parsed)
368 m_cacheControlHeader = parseCacheControlDirectives(m_httpHeaderFields.ge t(cacheControlHeaderString()), m_httpHeaderFields.get(pragmaHeaderString())); 368 m_cacheControlHeader = parseCacheControlDirectives(m_httpHeaderFields.ge t(cacheControlHeaderString()), m_httpHeaderFields.get(pragmaHeaderString()));
369 return m_cacheControlHeader.containsNoCache; 369 return m_cacheControlHeader.containsNoCache;
370 } 370 }
371 371
372 bool ResourceResponse::cacheControlContainsNoStore() 372 bool ResourceResponse::cacheControlContainsNoStore() const
373 { 373 {
374 if (!m_cacheControlHeader.parsed) 374 if (!m_cacheControlHeader.parsed)
375 m_cacheControlHeader = parseCacheControlDirectives(m_httpHeaderFields.ge t(cacheControlHeaderString()), m_httpHeaderFields.get(pragmaHeaderString())); 375 m_cacheControlHeader = parseCacheControlDirectives(m_httpHeaderFields.ge t(cacheControlHeaderString()), m_httpHeaderFields.get(pragmaHeaderString()));
376 return m_cacheControlHeader.containsNoStore; 376 return m_cacheControlHeader.containsNoStore;
377 } 377 }
378 378
379 bool ResourceResponse::cacheControlContainsMustRevalidate() 379 bool ResourceResponse::cacheControlContainsMustRevalidate() const
380 { 380 {
381 if (!m_cacheControlHeader.parsed) 381 if (!m_cacheControlHeader.parsed)
382 m_cacheControlHeader = parseCacheControlDirectives(m_httpHeaderFields.ge t(cacheControlHeaderString()), m_httpHeaderFields.get(pragmaHeaderString())); 382 m_cacheControlHeader = parseCacheControlDirectives(m_httpHeaderFields.ge t(cacheControlHeaderString()), m_httpHeaderFields.get(pragmaHeaderString()));
383 return m_cacheControlHeader.containsMustRevalidate; 383 return m_cacheControlHeader.containsMustRevalidate;
384 } 384 }
385 385
386 bool ResourceResponse::hasCacheValidatorFields() const 386 bool ResourceResponse::hasCacheValidatorFields() const
387 { 387 {
388 DEFINE_STATIC_LOCAL(const AtomicString, lastModifiedHeader, ("last-modified" )); 388 DEFINE_STATIC_LOCAL(const AtomicString, lastModifiedHeader, ("last-modified" ));
389 DEFINE_STATIC_LOCAL(const AtomicString, eTagHeader, ("etag")); 389 DEFINE_STATIC_LOCAL(const AtomicString, eTagHeader, ("etag"));
390 return !m_httpHeaderFields.get(lastModifiedHeader).isEmpty() || !m_httpHeade rFields.get(eTagHeader).isEmpty(); 390 return !m_httpHeaderFields.get(lastModifiedHeader).isEmpty() || !m_httpHeade rFields.get(eTagHeader).isEmpty();
391 } 391 }
392 392
393 double ResourceResponse::cacheControlMaxAge() 393 double ResourceResponse::cacheControlMaxAge() const
394 { 394 {
395 if (!m_cacheControlHeader.parsed) 395 if (!m_cacheControlHeader.parsed)
396 m_cacheControlHeader = parseCacheControlDirectives(m_httpHeaderFields.ge t(cacheControlHeaderString()), m_httpHeaderFields.get(pragmaHeaderString())); 396 m_cacheControlHeader = parseCacheControlDirectives(m_httpHeaderFields.ge t(cacheControlHeaderString()), m_httpHeaderFields.get(pragmaHeaderString()));
397 return m_cacheControlHeader.maxAge; 397 return m_cacheControlHeader.maxAge;
398 } 398 }
399 399
400 double ResourceResponse::cacheControlStaleWhileRevalidate() 400 double ResourceResponse::cacheControlStaleWhileRevalidate() const
401 { 401 {
402 if (!m_cacheControlHeader.parsed) 402 if (!m_cacheControlHeader.parsed)
403 m_cacheControlHeader = parseCacheControlDirectives(m_httpHeaderFields.ge t(cacheControlHeaderString()), m_httpHeaderFields.get(pragmaHeaderString())); 403 m_cacheControlHeader = parseCacheControlDirectives(m_httpHeaderFields.ge t(cacheControlHeaderString()), m_httpHeaderFields.get(pragmaHeaderString()));
404 return m_cacheControlHeader.staleWhileRevalidate; 404 return m_cacheControlHeader.staleWhileRevalidate;
405 } 405 }
406 406
407 static double parseDateValueInHeader(const HTTPHeaderMap& headers, const AtomicS tring& headerName) 407 static double parseDateValueInHeader(const HTTPHeaderMap& headers, const AtomicS tring& headerName)
408 { 408 {
409 const AtomicString& headerValue = headers.get(headerName); 409 const AtomicString& headerValue = headers.get(headerName);
410 if (headerValue.isEmpty()) 410 if (headerValue.isEmpty())
(...skipping 158 matching lines...) Expand 10 before | Expand all | Expand 10 after
569 if (a.httpHeaderFields() != b.httpHeaderFields()) 569 if (a.httpHeaderFields() != b.httpHeaderFields())
570 return false; 570 return false;
571 if (a.resourceLoadTiming() && b.resourceLoadTiming() && *a.resourceLoadTimin g() == *b.resourceLoadTiming()) 571 if (a.resourceLoadTiming() && b.resourceLoadTiming() && *a.resourceLoadTimin g() == *b.resourceLoadTiming())
572 return true; 572 return true;
573 if (a.resourceLoadTiming() != b.resourceLoadTiming()) 573 if (a.resourceLoadTiming() != b.resourceLoadTiming())
574 return false; 574 return false;
575 return true; 575 return true;
576 } 576 }
577 577
578 } // namespace blink 578 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/platform/network/ResourceResponse.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698