Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1980663003: Add a new QUIC ChloExtractor class used by the QuicProxyDispatcher to extract CHLO message from pac… (Closed)

Created:
4 years, 7 months ago by Buck
Modified:
4 years, 7 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@121403250
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a new QUIC ChloExtractor class used by the QuicProxyDispatcher to extract CHLO message from packets. protected by --quic_use_chlo_extractor This CL deprecates QuicPacketParser which allocates a clone of the CryptoHandshakeMessage making it somewhat undesirable for use in "cheap" stateless rejects. Merge internal change: 121416043 R=rch@chromium.org BUG=

Patch Set 1 #

Total comments: 4

Patch Set 2 : review feedback (#1) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+354 lines, -0 lines) Patch
M net/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M net/net.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M net/net.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A net/tools/quic/chlo_extractor.h View 1 chunk +40 lines, -0 lines 0 comments Download
A net/tools/quic/chlo_extractor.cc View 1 chunk +170 lines, -0 lines 0 comments Download
A net/tools/quic/chlo_extractor_test.cc View 1 1 chunk +139 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 4 (0 generated)
Buck
4 years, 7 months ago (2016-05-13 20:15:37 UTC) #1
Ryan Hamilton
https://codereview.chromium.org/1980663003/diff/1/net/quic/quic_flags.h File net/quic/quic_flags.h (right): https://codereview.chromium.org/1980663003/diff/1/net/quic/quic_flags.h#newcode34 net/quic/quic_flags.h:34: NET_EXPORT_PRIVATE extern bool FLAGS_quic_use_chlo_extractor; Sorry, I'm an idiot. I ...
4 years, 7 months ago (2016-05-13 20:27:09 UTC) #2
Buck
https://codereview.chromium.org/1980663003/diff/1/net/quic/quic_flags.h File net/quic/quic_flags.h (right): https://codereview.chromium.org/1980663003/diff/1/net/quic/quic_flags.h#newcode34 net/quic/quic_flags.h:34: NET_EXPORT_PRIVATE extern bool FLAGS_quic_use_chlo_extractor; On 2016/05/13 20:27:09, Ryan Hamilton ...
4 years, 7 months ago (2016-05-13 21:25:55 UTC) #3
Ryan Hamilton
4 years, 7 months ago (2016-05-13 21:42:27 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698