Issue 1974673004: Joins Cookie header components correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1974673004: Joins Cookie header components correctly. (Closed)

Created:
4 years, 7 months ago by Buck

Modified:
4 years, 7 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, Biren Roy

Base URL:
https://chromium.googlesource.com/chromium/src.git@121398461

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Joins Cookie header components correctly. A follow-on fix for internal change 121373674. RFC 7540 section 8.1.2.5 specifies that cookie crumbs should be reconstructed with a "; " delimiter. Merge internal change: 121403250 R=rch@chromium.org BUG=

Patch Set 1 #

Patch Set 2 : fixes for trybot detected errors #

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -1 line)			Patch
	M	net/quic/spdy_utils.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
	M	net/quic/spdy_utils_test.cc	View	1	2 chunks	+35 lines, -1 line	0 comments	Download

Depends on Patchset:

Issue 1978913002 Patch 1

Dependent Patchsets:

Issue 1980663003 Patch 20001

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

chromium-reviews

4 years, 7 months ago (2016-05-13 20:30:55 UTC) #3

looking into it now.. . one of them is windows compilation rejecting "9\09"
because it thinks it might be octal...

On Fri, May 13, 2016 at 1:25 PM, <rch@chromium.org> wrote:

> Any idea about the failing tests?
>
> https://codereview.chromium.org/1974673004/
>



-- 
Charles 'Buck' Krasic | Software Engineer | ckrasic@google.com | +1 (408)
412-1141

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Expand Messages | Collapse Messages