Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(896)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 198063003: Revert of Shelf Cleanup (- binary files) (Closed)

Created:
6 years, 9 months ago by jennyz
Modified:
6 years, 9 months ago
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

Revert of Shelf Cleanup (- binary files) (https://codereview.chromium.org/176883022/) Reason for revert: This cl is breaking the app list launch bubble. see crbug.com/351776. Original issue's description: > Shelf Cleanup (- binary files) > > R=skuhne@chromium.org > TBR=jamescook@chromium.org, miket@chromium.org, skuhne@chromium.org > BUG=338429 > > re-landing of > https://codereview.chromium.org/140323010/ hopefully this time with less breaking everything. > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256319 TBR=jamescook@chromium.org,skuhne@chromium.org,harrym@chromium.org NOTREECHECKS=true NOTRY=true BUG=338429 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256662

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1737 lines, -340 lines) Patch
M ash/ash.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/ash_switches.h View 3 chunks +5 lines, -5 lines 0 comments Download
M ash/ash_switches.cc View 3 chunks +16 lines, -6 lines 0 comments Download
M ash/dip_unittest.cc View 1 chunk +39 lines, -0 lines 0 comments Download
M ash/display/display_controller_unittest.cc View 1 chunk +94 lines, -0 lines 0 comments Download
M ash/resources/ash_resources.grd View 1 chunk +5 lines, -2 lines 0 comments Download
A ash/shelf/alternate_app_list_button.h View 1 chunk +59 lines, -0 lines 0 comments Download
A ash/shelf/alternate_app_list_button.cc View 1 chunk +174 lines, -0 lines 0 comments Download
M ash/shelf/app_list_button.h View 3 chunks +5 lines, -17 lines 0 comments Download
M ash/shelf/app_list_button.cc View 3 chunks +55 lines, -95 lines 0 comments Download
M ash/shelf/overflow_bubble_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/overflow_button.cc View 1 chunk +47 lines, -26 lines 0 comments Download
M ash/shelf/shelf_button.cc View 6 chunks +52 lines, -9 lines 0 comments Download
M ash/shelf/shelf_constants.h View 2 chunks +3 lines, -9 lines 0 comments Download
M ash/shelf/shelf_constants.cc View 1 chunk +1 line, -3 lines 0 comments Download
M ash/shelf/shelf_layout_manager.h View 1 chunk +8 lines, -0 lines 0 comments Download
M ash/shelf/shelf_layout_manager.cc View 6 chunks +46 lines, -15 lines 0 comments Download
M ash/shelf/shelf_model.cc View 2 chunks +40 lines, -19 lines 0 comments Download
M ash/shelf/shelf_model_unittest.cc View 2 chunks +113 lines, -0 lines 0 comments Download
M ash/shelf/shelf_navigator_unittest.cc View 5 chunks +65 lines, -0 lines 0 comments Download
M ash/shelf/shelf_view.h View 2 chunks +11 lines, -0 lines 0 comments Download
M ash/shelf/shelf_view.cc View 19 chunks +155 lines, -25 lines 0 comments Download
M ash/shelf/shelf_view_unittest.cc View 9 chunks +191 lines, -3 lines 0 comments Download
M ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc View 2 chunks +1 line, -2 lines 0 comments Download
M ash/system/session/logout_button_tray.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/status_area_widget_delegate.cc View 4 chunks +20 lines, -2 lines 0 comments Download
M ash/system/tray/system_tray.cc View 3 chunks +9 lines, -5 lines 0 comments Download
M ash/system/tray/tray_background_view.cc View 11 chunks +148 lines, -42 lines 0 comments Download
M ash/system/tray/tray_constants.h View 2 chunks +11 lines, -6 lines 0 comments Download
M ash/system/tray/tray_constants.cc View 2 chunks +18 lines, -6 lines 0 comments Download
M ash/system/user/tray_user.cc View 8 chunks +32 lines, -15 lines 0 comments Download
M ash/system/web_notification/web_notification_tray.cc View 7 chunks +14 lines, -10 lines 0 comments Download
M ash/test/shelf_view_test_api.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M ash/wm/app_list_controller.cc View 3 chunks +53 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/apps/chrome_app_window_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 4 chunks +13 lines, -6 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc View 3 chunks +214 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_favicon_loader_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jennyz
Created Revert of Shelf Cleanup (- binary files)
6 years, 9 months ago (2014-03-12 21:36:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennyz@chromium.org/198063003/1
6 years, 9 months ago (2014-03-12 21:39:44 UTC) #2
commit-bot: I haz the power
6 years, 9 months ago (2014-03-12 21:45:38 UTC) #3
Message was sent while issue was closed. 
Change committed as 256662

Powered by Google App Engine
This is Rietveld 408576698