Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: ash/dip_unittest.cc

Issue 198063003: Revert of Shelf Cleanup (- binary files) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/ash_switches.cc ('k') | ash/display/display_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/dip_unittest.cc
diff --git a/ash/dip_unittest.cc b/ash/dip_unittest.cc
index 2c15765d8675c6b2dcd0ccd08a8f9652356efdef..5fef4685f7c2c12cdd69ae643764ac1257f13277 100644
--- a/ash/dip_unittest.cc
+++ b/ash/dip_unittest.cc
@@ -69,4 +69,43 @@
shelf->shelf_widget()->GetNativeView()->layer()->bounds().height());
}
+TEST_F(DIPTest, WorkAreaForLegacyShelfLayout) {
+ CommandLine::ForCurrentProcess()->AppendSwitch(
+ ash::switches::kAshDisableAlternateShelfLayout);
+ UpdateDisplay("1000x900*1.0f");
+
+ aura::Window* root = Shell::GetPrimaryRootWindow();
+ const gfx::Display display =
+ Shell::GetScreen()->GetDisplayNearestWindow(root);
+
+ EXPECT_EQ("0,0 1000x900", display.bounds().ToString());
+ gfx::Rect work_area = display.work_area();
+ EXPECT_EQ("0,0 1000x852", work_area.ToString());
+ EXPECT_EQ("0,0,48,0", display.bounds().InsetsFrom(work_area).ToString());
+
+ UpdateDisplay("2000x1800*2.0f");
+ gfx::Screen* screen = Shell::GetScreen();
+
+ const gfx::Display display_2x = screen->GetDisplayNearestWindow(root);
+ const internal::DisplayInfo display_info_2x =
+ Shell::GetInstance()->display_manager()->GetDisplayInfo(display_2x.id());
+
+ // The |bounds_in_native()| should report bounds in pixel coordinate.
+ EXPECT_EQ("1,1 2000x1800",
+ display_info_2x.bounds_in_native().ToString());
+
+ // Aura and views coordinates are in DIP, so they their bounds do not change.
+ EXPECT_EQ("0,0 1000x900", display_2x.bounds().ToString());
+ work_area = display_2x.work_area();
+ EXPECT_EQ("0,0 1000x852", work_area.ToString());
+ EXPECT_EQ("0,0,48,0", display_2x.bounds().InsetsFrom(work_area).ToString());
+
+ // Sanity check if the workarea's inset hight is same as
+ // the shelf's height.
+ Shelf* shelf = Shelf::ForPrimaryDisplay();
+ EXPECT_EQ(
+ display_2x.bounds().InsetsFrom(work_area).height(),
+ shelf->shelf_widget()->GetNativeView()->layer()->bounds().height());
+}
+
} // namespace ash
« no previous file with comments | « ash/ash_switches.cc ('k') | ash/display/display_controller_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698