Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: chrome/browser/android/offline_pages/offline_page_bridge.cc

Issue 1980623003: Update offline pages UMAs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/offline_page_bridge.cc
diff --git a/chrome/browser/android/offline_pages/offline_page_bridge.cc b/chrome/browser/android/offline_pages/offline_page_bridge.cc
index d98654165ae103b9ed433d48660a7b757e871dbe..c268e43f4185cb62676a7c85d481c6976d1cb701 100644
--- a/chrome/browser/android/offline_pages/offline_page_bridge.cc
+++ b/chrome/browser/android/offline_pages/offline_page_bridge.cc
@@ -303,12 +303,15 @@ void OfflinePageBridge::SavePage(
ScopedJavaGlobalRef<jobject> j_callback_ref;
j_callback_ref.Reset(env, j_callback_obj);
+ GURL url;
+ std::unique_ptr<OfflinePageArchiver> archiver;
+
content::WebContents* web_contents =
content::WebContents::FromJavaWebContents(j_web_contents);
- GURL url(web_contents->GetLastCommittedURL());
-
- std::unique_ptr<OfflinePageArchiver> archiver(
- new OfflinePageMHTMLArchiver(web_contents));
+ if (web_contents) {
+ url = web_contents->GetLastCommittedURL();
+ archiver.reset(new OfflinePageMHTMLArchiver(web_contents));
+ }
offline_pages::ClientId client_id;
client_id.name_space = ConvertJavaStringToUTF8(env, j_namespace);

Powered by Google App Engine
This is Rietveld 408576698