Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(759)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java

Issue 1980623003: Update offline pages UMAs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/offline_page_bridge.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
index 401385217edbb59036ba97839b06214b9b97320e..25437827532bfa59fc14dc2a8ad228465ce9860e 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
@@ -30,7 +30,6 @@ import java.util.Set;
@JNINamespace("offline_pages::android")
public class OfflinePageBridge {
public static final String BOOKMARK_NAMESPACE = "bookmark";
- public static final long INVALID_OFFLINE_ID = 0;
/**
* Retrieves the OfflinePageBridge for the given profile, creating it the first time
@@ -390,13 +389,6 @@ public class OfflinePageBridge {
assert mIsNativeOfflinePageModelLoaded;
assert webContents != null;
- if (webContents.isDestroyed()) {
- callback.onSavePageDone(SavePageResult.CONTENT_UNAVAILABLE, null, INVALID_OFFLINE_ID);
- RecordHistogram.recordEnumeratedHistogram("OfflinePages.SavePageResult",
- SavePageResult.CONTENT_UNAVAILABLE, SavePageResult.RESULT_COUNT);
- return;
- }
-
SavePageCallback callbackWrapper = new SavePageCallback() {
@Override
public void onSavePageDone(int savePageResult, String url, long offlineId) {
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/offline_page_bridge.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698