Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 1980603002: Use new intrinsic content height when computing min-height: min-content (Closed)

Created:
4 years, 7 months ago by cbiesinger
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Use new intrinsic content height when computing min-height: min-content Instead of using the cached intrinsic content height, we should use the newly provided one, because that one is not out of date. BUG=606423 Review-Url: https://codereview.chromium.org/1971053003 Cr-Commit-Position: refs/heads/master@{#393385} (cherry picked from commit ed528b2c5a2eef209222118fc34b7d9e325c9939) Committed: https://chromium.googlesource.com/chromium/src/+/65bf99891b6b06580139f4ecd8944ab7789b6980

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -5 lines) Patch
A third_party/WebKit/LayoutTests/css3/flexbox/resize-min-content-flexbox.html View 1 chunk +38 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 4 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
cbiesinger
4 years, 7 months ago (2016-05-13 16:33:40 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
65bf99891b6b06580139f4ecd8944ab7789b6980.

Powered by Google App Engine
This is Rietveld 408576698