Use new intrinsic content height when computing min-height: min-content

Use new intrinsic content height when computing min-height: min-content

Instead of using the cached intrinsic content height, we should use
the newly provided one, because that one is not out of date.

BUG=606423
Committed: https://crrev.com/ed528b2c5a2eef209222118fc34b7d9e325c9939
Cr-Commit-Position: refs/heads/master@{#393385}

[cbiesinger, 2016-05-12 18:23:47]

The CQ bit was checked by cbiesinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-12 18:24:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1971053003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1971053003/20001

[cbiesinger, 2016-05-12 19:13:02]

The CQ bit was checked by cbiesinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-12 19:13:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1971053003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1971053003/40001

[cbiesinger, 2016-05-12 19:17:36]

cbiesinger@chromium.org changed reviewers:
+ eae@chromium.org, mstensho@opera.com

[cbiesinger, 2016-05-12 19:17:38]

Emil/Morten can you take a look? Thanks!

[eae, 2016-05-12 19:24:56]

https://codereview.chromium.org/1971053003/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/css3/flexbox/resize-min-content-flexbox.html
(right):

https://codereview.chromium.org/1971053003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/css3/flexbox/resize-min-content-flexbox.html:28:
onload = function() {
No need to use onload, place the script tag after the content and call the
methods directly instead. Will be slightly faster.

https://codereview.chromium.org/1971053003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutBox.cpp (right):

https://codereview.chromium.org/1971053003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutBox.cpp:2676: if
(intrinsicContentHeight != -1)
Shouldn't we be able to always use intrinsicContentHeight here?
m_intrinsicContentLogicalHeight can be -1 but isn't intrinsicContentHeight
guaranteed to be set here?

[cbiesinger, 2016-05-12 19:49:38]

The CQ bit was checked by cbiesinger@chromium.org to run a CQ dry run

[cbiesinger, 2016-05-12 19:49:45]

https://codereview.chromium.org/1971053003/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/css3/flexbox/resize-min-content-flexbox.html
(right):

https://codereview.chromium.org/1971053003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/css3/flexbox/resize-min-content-flexbox.html:28:
onload = function() {
On 2016/05/12 19:24:55, eae wrote:
> No need to use onload, place the script tag after the content and call the
> methods directly instead. Will be slightly faster.

Done.

https://codereview.chromium.org/1971053003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutBox.cpp (right):

https://codereview.chromium.org/1971053003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutBox.cpp:2676: if
(intrinsicContentHeight != -1)
On 2016/05/12 19:24:56, eae wrote:
> Shouldn't we be able to always use intrinsicContentHeight here?
> m_intrinsicContentLogicalHeight can be -1 but isn't intrinsicContentHeight
> guaranteed to be set here?

I believe you're correct, especially given that
computeContentAndScrollbarLogicalHeightUsing (=the main caller of this function)
returns -1 if intrinsic height is -1. Callers should just pass
intrinsicContentHeight() if desired.

availableLogicalHeight() might want to consider that... I added a FIXME comment.
And I fixed another caller to pass something better. Those two are the only ones
where it matters, I think.

[commit-bot: I haz the power, 2016-05-12 19:50:09]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1971053003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1971053003/80001

[eae, 2016-05-12 20:12:38]

LGTM

[cbiesinger, 2016-05-12 20:35:17]

The CQ bit was unchecked by cbiesinger@chromium.org

[cbiesinger, 2016-05-12 20:35:22]

The CQ bit was checked by cbiesinger@chromium.org

[commit-bot: I haz the power, 2016-05-12 20:35:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1971053003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1971053003/80001

[commit-bot: I haz the power, 2016-05-12 23:02:53]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-05-12 23:04:34]

Description was changed from

==========
Use new intrinsic content height when computing min-height: min-content

Instead of using the cached intrinsic content height, we should use
the newly provided one, because that one is not out of date.

BUG=606423
==========

to

==========
Use new intrinsic content height when computing min-height: min-content

Instead of using the cached intrinsic content height, we should use
the newly provided one, because that one is not out of date.

BUG=606423

Committed: https://crrev.com/ed528b2c5a2eef209222118fc34b7d9e325c9939
Cr-Commit-Position: refs/heads/master@{#393385}
==========

[commit-bot: I haz the power, 2016-05-12 23:04:36]

Patchset 5 (id:??) landed as
https://crrev.com/ed528b2c5a2eef209222118fc34b7d9e325c9939
Cr-Commit-Position: refs/heads/master@{#393385}