Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 198053014: ARM: fix assertions for uxtb and co. (Closed)

Created:
6 years, 9 months ago by Rodolph Perfetta (ARM)
Modified:
6 years, 9 months ago
Reviewers:
Benedikt Meurer, ulan
CC:
v8-dev
Visibility:
Public.

Description

ARM: fix assertions for uxtb and co. Allow operands with ROR #0. Behind the scene they are mapped to LSL #0. BUG=v8:3209 LOG=N R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20171

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -8 lines) Patch
M src/arm/assembler-arm.cc View 4 chunks +16 lines, -5 lines 0 comments Download
M src/arm/disasm-arm.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-disasm-arm.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Rodolph Perfetta (ARM)
6 years, 9 months ago (2014-03-21 13:28:37 UTC) #1
ulan
lgtm
6 years, 9 months ago (2014-03-21 15:22:33 UTC) #2
Rodolph Perfetta (ARM)
6 years, 9 months ago (2014-03-21 15:59:54 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20171 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698