Issue 198053011: DevTools: [CSS] remove StyleId and RuleId types from protocol.json

Issue 198053011: DevTools: [CSS] remove StyleId and RuleId types from protocol.json (Closed)

Created:
6 years, 9 months ago by lushnikov

Modified:
6 years, 8 months ago

Reviewers:
apavlov, vsevik

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: [CSS] remove StyleId and RuleId types from protocol.json This patch removes StyleId and RuleId types from protocol.json as they are not needed any more. BUG=341506 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170972

Patch Set 1 #

Patch Set 2 : rebaseline #

Total comments: 6

Patch Set 3 : address @apavlov comments #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -95 lines)			Patch
M	LayoutTests/inspector-protocol/css/css-set-inline-styleSheetText.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/inspector-protocol/css/css-set-property-text-inline.html	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/inspector/elements/styles/import-pseudoclass-crash.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/inspector/elements/styles/multiple-imports-edit-crash.html	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/inspector/elements/styles/styles-new-API.html	View	1	10 chunks	+14 lines, -15 lines	0 comments	Download
M	LayoutTests/inspector/elements/styles/undo-add-new-rule.html	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/inspector/InspectorStyleSheet.h	View	1	2 chunks	+0 lines, -23 lines	0 comments	Download
M	Source/core/inspector/InspectorStyleSheet.cpp	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/devtools/front_end/CSSStyleModel.js	View	1	12 chunks	+21 lines, -19 lines	0 comments	Download
M	Source/devtools/front_end/StylesSidebarPane.js	View	1	9 chunks	+10 lines, -10 lines	0 comments	Download
M	Source/devtools/protocol.json	View	1 2	4 chunks	+3 lines, -21 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

apavlov

lgtm with comments https://codereview.chromium.org/198053011/diff/20001/Source/core/inspector/InspectorStyleSheet.h File Source/core/inspector/InspectorStyleSheet.h (left): https://codereview.chromium.org/198053011/diff/20001/Source/core/inspector/InspectorStyleSheet.h#oldcode58 Source/core/inspector/InspectorStyleSheet.h:58: class InspectorCSSId { You don't seem ...

6 years, 8 months ago (2014-04-07 12:40:58 UTC) #3

lushnikov

https://codereview.chromium.org/198053011/diff/20001/Source/core/inspector/InspectorStyleSheet.h File Source/core/inspector/InspectorStyleSheet.h (left): https://codereview.chromium.org/198053011/diff/20001/Source/core/inspector/InspectorStyleSheet.h#oldcode58 Source/core/inspector/InspectorStyleSheet.h:58: class InspectorCSSId { On 2014/04/07 12:40:58, apavlov wrote: > ...

6 years, 8 months ago (2014-04-07 13:13:48 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/198053011/40001

6 years, 8 months ago (2014-04-07 13:37:40 UTC) #7

Message was sent while issue was closed.

Change committed as 170972

Expand Messages | Collapse Messages