Source/core/inspector/InspectorStyleSheet.cpp - Issue 198053011: DevTools: [CSS] remove StyleId and RuleId types from protocol.json

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorStyleSheet.cpp

Issue 198053011: DevTools: [CSS] remove StyleId and RuleId types from protocol.json (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: address @apavlov comments Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/inspector/InspectorStyleSheet.cpp

diff --git a/Source/core/inspector/InspectorStyleSheet.cpp b/Source/core/inspector/InspectorStyleSheet.cpp

index 4460f3fffb3bee6c2741fd61bc78d5a4f6659e90..d298cc4b4869ebfaf9856fe05c26a8a1b343f3c3 100644

--- a/Source/core/inspector/InspectorStyleSheet.cpp

+++ b/Source/core/inspector/InspectorStyleSheet.cpp

@@ -522,7 +522,7 @@ PassRefPtr<TypeBuilder::CSS::CSSStyle> InspectorStyle::buildObjectForStyle() con

{

RefPtr<TypeBuilder::CSS::CSSStyle> result = styleWithProperties();

if (!m_styleId.isEmpty())

- result->setStyleId(m_styleId.asProtocolValue<TypeBuilder::CSS::CSSStyleId>());

+ result->setStyleSheetId(m_styleId.styleSheetId());

RefPtrWillBeRawPtr<CSSRuleSourceData> sourceData = extractSourceData();

if (sourceData)

@@ -1235,7 +1235,7 @@ PassRefPtr<TypeBuilder::CSS::CSSRule> InspectorStyleSheet::buildObjectForRule(CS

if (canBind(m_origin)) {

InspectorCSSId id(ruleId(rule));

if (!id.isEmpty())

- result->setRuleId(id.asProtocolValue<TypeBuilder::CSS::CSSRuleId>());

+ result->setStyleSheetId(id.styleSheetId());

}

if (mediaStack)